churn: fix exec test under go 1.17+ (argoproj#275)

Signed-off-by: Artur Rodrigues <[email protected]>
iguazio · Dec 21, 2022 · fa80524 · fa80524
1 parent d365d6f
commit fa80524
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -16,7 +16,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v3
         with:
-          go-version: 1.15
+          go-version: 1.19
 
       - name: Build
         run: |

diff --git a/exec/exec_test.go b/exec/exec_test.go
@@ -99,14 +99,12 @@ func TestRunCommandExitErr(t *testing.T) {
 }
 
 func TestRunCommandErr(t *testing.T) {
-	//_ := test.NewGlobal()
 	log.SetLevel(log.DebugLevel)
 	defer log.SetLevel(log.InfoLevel)
 
-	// this would create a panic
-	output, err := RunCommand("", CmdOpts{Redactor: Redact([]string{"world"})})
+	output, err := RunCommand("sh", CmdOpts{Redactor: Redact([]string{"world"})}, "-c", ">&2 echo 'failure'; false")
 	assert.Empty(t, output)
-	assert.EqualError(t, err, "fork/exec : no such file or directory")
+	assert.EqualError(t, err, "`sh -c >&2 echo 'failure'; false` failed exit status 1: failure")
 }
 
 func TestRunInDir(t *testing.T) {