benchmark: support URL inputs in create-clientrequest

This patch adds the option in the create-clientrequest benchmark to accept URL inputs (as strings or as URL objects) so we can measure the impact of URL parsing in a more sophisticated use case. PR-URL: nodejs#24302 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
ihiteshsharma · Nov 19, 2018 · 8450d11 · 8450d11
1 parent a365bb9
commit 8450d11
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 10 deletions.
diff --git a/benchmark/http/create-clientrequest.js b/benchmark/http/create-clientrequest.js
@@ -2,19 +2,49 @@
 
 const common = require('../common.js');
 const ClientRequest = require('http').ClientRequest;
-
+const types = Object.keys(common.urls)
+  .filter((i) => common.urls[i]
+  .startsWith('http://'));
 const bench = common.createBenchmark(main, {
-  len: [1, 8, 16, 32, 64, 128],
-  n: [1e6]
+  // Use 'url' to avoid name clash with other http benchmark
+  url: types.concat(['wpt']),
+  arg: ['URL', 'string', 'options'],
+  e: [1]
 });
 
-function main({ len, n }) {
-  const path = '/'.repeat(len);
-  const opts = { path: path, createConnection: function() {} };
+function noop() {}
 
-  bench.start();
-  for (var i = 0; i < n; i++) {
-    new ClientRequest(opts);
+function main({ url: type, arg, e }) {
+  e = +e;
+  const data = common.bakeUrlData(type, e, false, false)
+    .filter((i) => i.startsWith('http://'));
+  const len = data.length;
+  var result;
+  var i;
+  if (arg === 'options') {
+    const options = data.map((i) => ({
+      path: new URL(i).path, createConnection: noop
+    }));
+    bench.start();
+    for (i = 0; i < len; i++) {
+      result = new ClientRequest(options[i]);
+    }
+    bench.end(len);
+  } else if (arg === 'URL') {
+    const options = data.map((i) => new URL(i));
+    bench.start();
+    for (i = 0; i < len; i++) {
+      result = new ClientRequest(options[i], { createConnection: noop });
+    }
+    bench.end(len);
+  } else if (arg === 'string') {
+    bench.start();
+    for (i = 0; i < len; i++) {
+      result = new ClientRequest(data[i], { createConnection: noop });
+    }
+    bench.end(len);
+  } else {
+    throw new Error(`Unknown arg type ${arg}`);
   }
-  bench.end(n);
+  require('assert').ok(result);
 }
diff --git a/test/benchmark/test-benchmark-http.js b/test/benchmark/test-benchmark-http.js
@@ -15,6 +15,9 @@ runBenchmark('http',
              [
                'benchmarker=test-double-http',
                'c=1',
+               'e=0',
+               'url=long',
+               'arg=string',
                'chunkedEnc=true',
                'chunks=0',
                'dur=0.1',