inspector: add debugging for WebSocket messages

PR-URL: nodejs#21473 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: James M Snell <[email protected]>
ihiteshsharma · Jun 26, 2018 · 8836a0d · 8836a0d
1 parent 65f6173
commit 8836a0d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/env.h b/src/env.h
@@ -415,10 +415,10 @@ struct ContextInfo {
 };
 
 // Listing the AsyncWrap provider types first enables us to cast directly
-// from a provider type to a debug category. Currently no other debug
-// categories are available.
+// from a provider type to a debug category.
 #define DEBUG_CATEGORY_NAMES(V) \
-    NODE_ASYNC_PROVIDER_TYPES(V)
+    NODE_ASYNC_PROVIDER_TYPES(V) \
+    V(INSPECTOR_SERVER)
 
 enum class DebugCategory {
 #define V(name) name,

diff --git a/src/inspector_io.cc b/src/inspector_io.cc
@@ -314,6 +314,8 @@ void InspectorIo::SwapBehindLock(MessageQueue<ActionType>* vector1,
 
 void InspectorIo::PostIncomingMessage(InspectorAction action, int session_id,
                                       const std::string& message) {
+  Debug(parent_env_, DebugCategory::INSPECTOR_SERVER,
+        ">>> %s\n", message.c_str());
   if (AppendMessage(&incoming_message_queue_, action, session_id,
                     Utf8ToStringView(message))) {
     Agent* agent = main_thread_req_->second;
@@ -395,6 +397,10 @@ void InspectorIo::MainThreadReqAsyncCb(uv_async_t* req) {
 
 void InspectorIo::Write(TransportAction action, int session_id,
                         const StringView& inspector_message) {
+  std::string message_str =
+      protocol::StringUtil::StringViewToUtf8(inspector_message);
+  Debug(parent_env_, DebugCategory::INSPECTOR_SERVER,
+        "<<< %s\n", message_str.c_str());
   AppendMessage(&outgoing_message_queue_, action, session_id,
                 StringBuffer::create(inspector_message));
   int err = uv_async_send(&thread_req_);