Skip to content

Commit

Permalink
build: do not lint on non-PR Travis builds
Browse files Browse the repository at this point in the history
Do not run any linting at all when `TRAVIS_PULL_REQUEST` is `false`.
This would otherwise break Travis CI for `master` and release branches.

Refs: nodejs#24030

PR-URL: nodejs#24076
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
  • Loading branch information
addaleax authored and Trott committed Nov 4, 2018
1 parent c6d29cc commit bde8eb5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ matrix:
script:
- make lint
# Lint the first commit in the PR.
- \[ "${TRAVIS_PULL_REQUEST}" != "false" \] && PR_ID=${TRAVIS_PULL_REQUEST}; bash tools/lint-pr-commit-message.sh ${PR_ID}
- \[ "${TRAVIS_PULL_REQUEST}" != "false" \] && bash tools/lint-pr-commit-message.sh ${TRAVIS_PULL_REQUEST}
- name: "Test Suite"
addons:
apt:
Expand Down

0 comments on commit bde8eb5

Please sign in to comment.