Invoking proxyToServerConnectionFailed when proxy cannot connect to s…

…erver
ikostov · Jul 5, 2015 · 779e6df · 779e6df
1 parent ec49ed2
commit 779e6df
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 0 deletions.
diff --git a/src/main/java/org/littleshoot/proxy/impl/ClientToProxyConnection.java b/src/main/java/org/littleshoot/proxy/impl/ClientToProxyConnection.java
@@ -523,6 +523,7 @@ protected boolean serverConnectionFailed(
                         serverConnection.getRemoteAddress(),
                         lastStateBeforeFailure,
                         cause);
+                currentFilters.proxyToServerConnectionFailed();
                 connectionFailedUnrecoverably(initialRequest);
                 return false;
             }

diff --git a/src/test/java/org/littleshoot/proxy/HttpFilterTest.java b/src/test/java/org/littleshoot/proxy/HttpFilterTest.java
@@ -434,6 +434,37 @@ public void proxyToServerResolutionSucceeded(String serverHostAndPort, InetSocke
         assertTrue("proxyToServerResolutionFailed method was not called", resolutionFailed.get());
     }
 
+    @Test
+    public void testConnectionFailedCalledAfterConnectionFailure() throws Exception {
+        final AtomicBoolean connectionFailed = new AtomicBoolean(false);
+        final AtomicBoolean connectionSucceeded = new AtomicBoolean(false);
+
+        HttpFiltersSource filtersSource = new HttpFiltersSourceAdapter() {
+            @Override
+            public HttpFilters filterRequest(HttpRequest originalRequest) {
+                return new HttpFiltersAdapter(originalRequest) {
+                    @Override
+                    public void proxyToServerConnectionFailed() {
+                        connectionFailed.set(true);
+                    }
+
+                    @Override
+                    public void proxyToServerConnectionSucceeded() {
+                        connectionSucceeded.set(true);
+                    }
+                };
+            }
+        };
+
+        setUpHttpProxyServer(filtersSource);
+
+        // port 0 is not connectable
+        getResponse("http://localhost:0/some-resource");
+
+        assertFalse("proxyToServerConnectionSucceeded method was called but should not have been", connectionSucceeded.get());
+        assertTrue("proxyToServerConnectionFailed method was not called", connectionFailed.get());
+    }
+
     @Test
     public void testRequestSentInvokedAfterLastHttpContentSent() throws Exception {
         final AtomicBoolean lastHttpContentProcessed = new AtomicBoolean(false);