Resolve facets in parallel (bluesky-social#2957)

* Detect facets in parallel * Add changeset
iksmn · Nov 8, 2024 · b6eeb81 · b6eeb81
1 parent 124eaee
commit b6eeb81
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/.changeset/dirty-trees-whisper.md b/.changeset/dirty-trees-whisper.md
@@ -0,0 +1,5 @@
+---
+"@atproto/api": patch
+---
+
+Detect facets in parallel
diff --git a/packages/api/src/rich-text/rich-text.ts b/packages/api/src/rich-text/rich-text.ts
@@ -350,17 +350,23 @@ export class RichText {
   async detectFacets(agent: AtpBaseClient) {
     this.facets = detectFacets(this.unicodeText)
     if (this.facets) {
+      const promises: Promise<void>[] = []
       for (const facet of this.facets) {
         for (const feature of facet.features) {
           if (AppBskyRichtextFacet.isMention(feature)) {
-            const did = await agent.com.atproto.identity
-              .resolveHandle({ handle: feature.did })
-              .catch((_) => undefined)
-              .then((res) => res?.data.did)
-            feature.did = did || ''
+            promises.push(
+              agent.com.atproto.identity
+                .resolveHandle({ handle: feature.did })
+                .then((res) => res?.data.did)
+                .catch((_) => undefined)
+                .then((did) => {
+                  feature.did = did || ''
+                }),
+            )
           }
         }
       }
+      await Promise.allSettled(promises)
       this.facets.sort(facetSort)
     }
   }