core: ofnode: Fix mem leak in error path

A newly created property is currently not freed if a name could not be allocated. This patch fixes the resulting memory leak in the error patch. Reported-by: Coverity (CID: 184085) Fixes: e369e58 ("core: Add functions to set properties in live-tree") Signed-off-by: Mario Six <[email protected]>
imaami · Nov 14, 2018 · 205dd5a · 205dd5a
1 parent ab88bd2
commit 205dd5a
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/drivers/core/ofnode.c b/drivers/core/ofnode.c
@@ -831,8 +831,10 @@ int ofnode_write_prop(ofnode node, const char *propname, int len,
 		return -ENOMEM;
 
 	new->name = strdup(propname);
-	if (!new->name)
+	if (!new->name) {
+		free(new);
 		return -ENOMEM;
+	}
 
 	new->value = (void *)value;
 	new->length = len;