Skip to content

Commit

Permalink
mmc: rockchip_sdhci: Remove empty get_phy and set_enhanced_strobe ops
Browse files Browse the repository at this point in the history
Remove empty implementations of get_phy and set_enhanced_strobe ops.
Change driver set_enhanced_strobe to return 0 in order to allow missing
implementation of the ops.

Signed-off-by: Jonas Karlman <[email protected]>
Reviewed-by: Kever Yang <[email protected]>
  • Loading branch information
Kwiboo authored and keveryang committed Apr 21, 2023
1 parent 6de4438 commit 667576c
Showing 1 changed file with 1 addition and 13 deletions.
14 changes: 1 addition & 13 deletions drivers/mmc/rockchip_sdhci.c
Original file line number Diff line number Diff line change
Expand Up @@ -365,16 +365,6 @@ static int rk3568_sdhci_config_dll(struct sdhci_host *host, u32 clock, bool enab
return 0;
}

static int rk3568_emmc_get_phy(struct udevice *dev)
{
return 0;
}

static int rk3568_sdhci_set_enhanced_strobe(struct sdhci_host *host)
{
return 0;
}

static int rk3568_sdhci_set_ios_post(struct sdhci_host *host)
{
struct mmc *mmc = host->mmc;
Expand Down Expand Up @@ -525,7 +515,7 @@ static int rockchip_sdhci_set_enhanced_strobe(struct sdhci_host *host)
if (data->set_enhanced_strobe)
return data->set_enhanced_strobe(host);

return -ENOTSUPP;
return 0;
}

static struct sdhci_ops rockchip_sdhci_ops = {
Expand Down Expand Up @@ -615,11 +605,9 @@ static const struct sdhci_data rk3399_data = {
};

static const struct sdhci_data rk3568_data = {
.get_phy = rk3568_emmc_get_phy,
.set_ios_post = rk3568_sdhci_set_ios_post,
.set_clock = rk3568_sdhci_set_clock,
.config_dll = rk3568_sdhci_config_dll,
.set_enhanced_strobe = rk3568_sdhci_set_enhanced_strobe,
};

static const struct udevice_id sdhci_ids[] = {
Expand Down

0 comments on commit 667576c

Please sign in to comment.