Bug fix in freeze encoder (coqui-ai#1391)

* Fix the bug in freeze encoder * Remove emb_l definition for non-multilingual training * Fix unit tests
imandana · Mar 24, 2022 · 37896e1 · 37896e1
1 parent 464dc65
commit 37896e1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/TTS/tts/models/vits.py b/TTS/tts/models/vits.py
@@ -706,7 +706,6 @@ def init_multilingual(self, config: Coqpit):
             torch.nn.init.xavier_uniform_(self.emb_l.weight)
         else:
             self.embedded_language_dim = 0
-            self.emb_l = None
 
     def get_aux_input(self, aux_input: Dict):
         sid, g, lid = self._set_cond_input(aux_input)

diff --git a/tests/tts_tests/test_vits.py b/tests/tts_tests/test_vits.py
@@ -79,25 +79,25 @@ def test_init_multilingual(self):
         model = Vits(args)
         self.assertEqual(model.language_manager, None)
         self.assertEqual(model.embedded_language_dim, 0)
-        self.assertEqual(model.emb_l, None)
+        assertHasNotAttr(self, model, "emb_l")
 
         args = VitsArgs(language_ids_file=LANG_FILE)
         model = Vits(args)
         self.assertNotEqual(model.language_manager, None)
         self.assertEqual(model.embedded_language_dim, 0)
-        self.assertEqual(model.emb_l, None)
+        assertHasNotAttr(self, model, "emb_l")
 
         args = VitsArgs(language_ids_file=LANG_FILE, use_language_embedding=True)
         model = Vits(args)
         self.assertNotEqual(model.language_manager, None)
         self.assertEqual(model.embedded_language_dim, args.embedded_language_dim)
-        self.assertNotEqual(model.emb_l, None)
+        assertHasAttr(self, model, "emb_l")
 
         args = VitsArgs(language_ids_file=LANG_FILE, use_language_embedding=True, embedded_language_dim=102)
         model = Vits(args)
         self.assertNotEqual(model.language_manager, None)
         self.assertEqual(model.embedded_language_dim, args.embedded_language_dim)
-        self.assertNotEqual(model.emb_l, None)
+        assertHasAttr(self, model, "emb_l")
 
     def test_get_aux_input(self):
         aux_input = {"speaker_ids": None, "style_wav": None, "d_vectors": None, "language_ids": None}