fix problem with HMR when middleware and page reference the same node…

…_module (vercel#33873)

fixes vercel#31827



## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`

packages/next/build/webpack-config.ts

@@ -959,11 +959,6 @@ export default async function getBaseWebpackConfig(
     },
   }
 
-  const nonUserCondition = {
-    include: /node_modules/,
-    exclude: babelIncludeRegexes,
-  }
-
   let webpackConfig: webpack.Configuration = {
     parallelism: Number(process.env.NEXT_WEBPACK_PARALLELISM) || undefined,
     externals: targetWeb
@@ -1256,13 +1251,6 @@ export default async function getBaseWebpackConfig(
             },
           ],
         },
-        {
-          ...nonUserCondition,
-          // Make all non-user modules to be compiled in a single layer
-          // This avoids compiling them mutliple times and avoids module id changes
-          issuerLayer: 'middleware',
-          layer: '',
-        },
         ...(!config.images.disableStaticImages
           ? [
               {

test/integration/middleware/hmr/pages/about/_middleware.js

@@ -1,5 +1,7 @@
 import { NextResponse } from 'next/server'
+import magicValue from 'shared-package'
 
 export function middleware(request) {
+  if (magicValue !== 42) throw new Error('shared-package problem')
   return NextResponse.rewrite(new URL('/about/a', request.url))
 }

test/integration/middleware/hmr/pages/index.js

@@ -1,3 +1,6 @@
+import magicValue from 'shared-package'
+if (magicValue !== 42) throw new Error('shared-package problem')
+
 export default function Home() {
   return (
     <div>