Fixed bug phpGH-8943 Reflection::getModifiersNames() with readonly mo…

…difier
imme-emosol · Jul 7, 2022 · c650e67 · c650e67
1 parent de202a5
commit c650e67
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/ext/reflection/php_reflection.c b/ext/reflection/php_reflection.c
@@ -1550,6 +1550,10 @@ ZEND_METHOD(Reflection, getModifierNames)
 	if (modifiers & ZEND_ACC_STATIC) {
 		add_next_index_stringl(return_value, "static", sizeof("static")-1);
 	}
+
+	if (modifiers & ZEND_ACC_READONLY) {
+		add_next_index_stringl(return_value, "readonly", sizeof("readonly")-1);
+	}
 }
 /* }}} */
 

diff --git a/ext/reflection/tests/Reflection_getModifierNames_001.phpt b/ext/reflection/tests/Reflection_getModifierNames_001.phpt
@@ -0,0 +1,23 @@
+--TEST--
+Reflection::getModifierNames() basic
+--FILE--
+<?php
+
+function printModifiers($modifiers) {
+	echo implode(',', Reflection::getModifierNames($modifiers)), PHP_EOL;
+}
+
+printModifiers(ReflectionProperty::IS_PRIVATE);
+printModifiers(ReflectionProperty::IS_PROTECTED | ReflectionProperty::IS_STATIC);
+printModifiers(ReflectionProperty::IS_PUBLIC | ReflectionProperty::IS_READONLY);
+printModifiers(ReflectionClass::IS_EXPLICIT_ABSTRACT);
+printModifiers(ReflectionMethod::IS_ABSTRACT | ReflectionMethod::IS_FINAL);
+printModifiers(ReflectionProperty::IS_PUBLIC | ReflectionProperty::IS_STATIC | ReflectionProperty::IS_READONLY);
+?>
+--EXPECT--
+private
+protected,static
+public,readonly
+abstract
+abstract,final
+public,static,readonly