Move OSR related APIs to Common (dotnet#34232)

Also unifying the style with the others that just throw.
immense055 · Mar 28, 2020 · 3410ce4 · 3410ce4
1 parent f306756
commit 3410ce4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 18 deletions.
diff --git a/src/coreclr/src/tools/Common/JitInterface/CorInfoImpl.cs b/src/coreclr/src/tools/Common/JitInterface/CorInfoImpl.cs
@@ -903,6 +903,10 @@ private bool satisfiesMethodConstraints(CORINFO_CLASS_STRUCT_* parent, CORINFO_M
         { throw new NotImplementedException("satisfiesMethodConstraints"); }
         private bool isCompatibleDelegate(CORINFO_CLASS_STRUCT_* objCls, CORINFO_CLASS_STRUCT_* methodParentCls, CORINFO_METHOD_STRUCT_* method, CORINFO_CLASS_STRUCT_* delegateCls, ref bool pfIsOpenDelegate)
         { throw new NotImplementedException("isCompatibleDelegate"); }
+        private void setPatchpointInfo(PatchpointInfo* patchpointInfo)
+        { throw new NotImplementedException("setPatchpointInfo"); }
+        private PatchpointInfo* getOSRInfo(ref uint ilOffset)
+        { throw new NotImplementedException("getOSRInfo"); }
 
         private void methodMustBeLoadedBeforeCodeIsRun(CORINFO_METHOD_STRUCT_* method)
         {

diff --git a/src/coreclr/src/tools/crossgen2/ILCompiler.ReadyToRun/JitInterface/CorInfoImpl.ReadyToRun.cs b/src/coreclr/src/tools/crossgen2/ILCompiler.ReadyToRun/JitInterface/CorInfoImpl.ReadyToRun.cs
@@ -2178,24 +2178,6 @@ private void getGSCookie(IntPtr* pCookieVal, IntPtr** ppCookieVal)
             *ppCookieVal = (IntPtr *)ObjectToHandle(_compilation.NodeFactory.GetReadyToRunHelperCell(ReadyToRunHelper.GSCookie));
         }
 
-        /// <summary>
-        /// Record patchpoint info for the method
-        /// </summary>
-        private void setPatchpointInfo(PatchpointInfo* patchpointInfo)
-        {
-            // No patchpoint info when prejitting
-            throw new NotImplementedException();
-        }
-
-        /// <summary>
-        /// Retrieve OSR info for the method
-        /// </summary>
-        private PatchpointInfo* getOSRInfo(ref uint ilOffset)
-        {
-            // No patchpoint info when prejitting
-            throw new NotImplementedException();
-        }
-
         private void getMethodVTableOffset(CORINFO_METHOD_STRUCT_* method, ref uint offsetOfIndirection, ref uint offsetAfterIndirection, ref bool isRelative)
         { throw new NotImplementedException("getMethodVTableOffset"); }
         private void expandRawHandleIntrinsic(ref CORINFO_RESOLVED_TOKEN pResolvedToken, ref CORINFO_GENERICHANDLE_RESULT pResult)