Correctly add 'dom-overlay' to optionalFeatures in case of an 'immersive-ar' session #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems there's already a PR with this exact same fix: #117 |
|
I'll close mine (#117) in favor of this one. It's exactly the same fix. |
|
Thanks for the fix, sorry about missing the earlier one. |
|
Thanks Klaus, and I'm also sorry about missing the previous fix! Thank you for bringing it to our attention again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying out the report page on the Pico Browser of the Pico Neo3 Link, the 'Begin Session' button for
immersive-ardid nothing. Hooking up a debugger showed an error thatoptionalFeatureswas not defined. A quick look at the code revealed that it indeed attempts to add thedom-overlaydirectly tooptionalFeatures, but this is part of thesessionOptions. This PR fixes that issue.