Include scope(list of permissions) you want to request from the user. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Здравствуйте! Синтаксис для хешей public_key: ENV['APP_PUBLIC_KEY'] сломает поддержку Ruby 1.8.X. |
|
|
||
| ```ruby | ||
| use OmniAuth::Builder do | ||
| provider :odnoklassniki, ENV['APP_ID'], ENV['APP_SECRET_KEY'], public_key: ENV['APP_PUBLIC_KEY'] |
There was a problem hiding this comment.
Мой косяк.
Забыл запятую:)
|
@incubus в README можно рекомендовать новый стиль ;). Просто можно добавить также список поддерживаемых версий руби. |
|
Не проще ли оставить старый синтаксис? :) |
|
Я отправлю заново пулл реквест в отдельной ветке, т.к. не делал его в отдельной ветке(мой косяк). |
cybernetlab
added a commit
to plandex/omniauth-odnoklassniki
that referenced
this pull request
Aug 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, I added the ability to define the parameters for adding scope permissions for user.
Scope parameters:
http://dev.odnoklassniki.ru/wiki/pages/viewpage.action?pageId=12878032