Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed navlink class and added query params to nav links list component #56

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Changed navlink class and added query params to nav links list component #56

merged 2 commits into from
Apr 29, 2024

Conversation

CostaArg
Copy link
Contributor

No description provided.

@CostaArg CostaArg marked this pull request as ready for review April 29, 2024 11:08
@CostaArg CostaArg requested a review from itsenes April 29, 2024 11:08
itsenes
itsenes approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@itsenes itsenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, perhaps we could support path to be both string and array of strings in the near future

@itsenes itsenes merged commit a17a5c5 into develop Apr 29, 2024
@CostaArg CostaArg deleted the feature/add-query-params-to-navlink branch May 1, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsenes itsenes itsenes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CostaArg @itsenes