Skip to content

Commit

Permalink
Show QA actions on changes_acceptance
Browse files Browse the repository at this point in the history
  • Loading branch information
duartegalvao authored and ThiefMaster committed Jan 17, 2024
1 parent 278a925 commit 0f39e21
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion openreferee_server/operations.py
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ def process_accepted_revision(event, revision):
def _can_access_action(revision, action, user):
if not any(x["code"] in ACTION_ROLES for x in user["roles"]):
return False
if revision["type"]["name"] == "acceptance":
if revision["type"]["name"] in {'acceptance', 'changes_acceptance'}:
if any(t["code"] == Tag.QA_PENDING for t in revision["tags"]):
return action in ("approve-qa", "fail-qa")
return action == "fail-qa"
Expand Down
2 changes: 1 addition & 1 deletion openreferee_server/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ def review_editable(
"A new revision %r was submitted for contribution %r", revision_id, contrib_id
)
resp = {}
if action == "accept":
if action in {'accept', 'update_accept'}:
resp = process_accepted_revision(event, revision)

return ReviewResponseSchema().dump(resp), 201
Expand Down

0 comments on commit 0f39e21

Please sign in to comment.