Issue with string shortcuts failing on primitives. (Issue andrewplumm…

…er#600)

lib/common.js

@@ -425,7 +425,7 @@ function deepSetProperty(obj, key, val) {
 
 function handleDeepProperty(obj, key, any, has, fill, fillLast, val) {
   var ns, bs, ps, cbi, set, isLast, isPush, isIndex, nextIsIndex, exists;
-  ns = obj || undefined;
+  ns = obj;
   if (key == null) return;
 
   if (isObjectType(key)) {
@@ -486,7 +486,9 @@ function handleDeepProperty(obj, key, any, has, fill, fillLast, val) {
       // 2nd part, if there is only 1 part, or if there is an explicit key.
       if (i || key || blen === 1) {
 
-        exists = any ? key in ns : hasOwn(ns, key);
+        // TODO: need to be sure this check handles ''.length when
+        // we refactor.
+        exists = any ? key in Object(ns) : hasOwn(ns, key);
 
         // Non-existent namespaces are only filled if they are intermediate
         // (not at the end) or explicitly filling the last.
@@ -886,7 +888,7 @@ function mapWithShortcuts(el, f, context, mapArgs) {
   } else if (isFunction(el[f])) {
     return el[f].call(el);
   } else {
-    return deepGetProperty(el, f);
+    return deepGetProperty(el, f, true);
   }
 }
 

test/tests/enumerable.js

@@ -1462,6 +1462,7 @@ namespace('Array', function() {
   });
 
   method('max', function() {
+
     test([12,87,55], 87, 'no argument');
     test([12,87,55], oneUndefined, 87, 'undefined');
     test([12,87,55], [null], 87, 'null');
@@ -1506,8 +1507,12 @@ namespace('Array', function() {
     test(arr, ['a.b.c'], {id:1,a:{b:{c:6}}}, 'by deep dot operator');
     test(arr, [true, 'a.b.c'], [{id:1,a:{b:{c:6}}},{id:2,a:{b:{c:6}}}], 'by deep dot operator multiple');
 
+    test(['one','two','three'], ['length'], 'three', 'Shold allow a string property');
+    test(['','two','three'], ['length'], 'three', 'Shold allow an empty string');
+
   });
 
+
   method('least', function() {
 
     var fn, arr;