-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully separate schema: common vs tenant #117
Open
mjsteckel
wants to merge
5
commits into
influitive:master
Choose a base branch
from
mjsteckel:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
dbcb828
Reworked things to:
mjsteckel 3c0f433
Added support for lambdas and hashes for persistent_schema.
mjsteckel 45e14a7
Minor bug fix, plus examples in template.
mjsteckel c4495ee
Ensure that the schema_migrations table exists in the tenant
mjsteckel a0c7b10
Only dump the schema for the specified tenant, not the entire
mjsteckel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Reworked things to:
1) maintain separation between "common" and tenant schemas (means that "common" tables are not also in the tenant schema!) 2) taks to process all tenants or a single tenant 3) support for per tenant migrations (potentially scary) 4) changed default so that db:migrate does NOT run apartment migrations.
- Loading branch information
commit dbcb828bde27536ff63f302b59c1ede514303e04
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,27 +7,39 @@ module Migrator | |
|
||
# Migrate to latest | ||
def migrate(database) | ||
Database.process(database) do | ||
Database.process(database, true) do | ||
version = ENV["VERSION"] ? ENV["VERSION"].to_i : nil | ||
|
||
ActiveRecord::Migrator.migrate(ActiveRecord::Migrator.migrations_paths, version) do |migration| | ||
ActiveRecord::Migrator.migrate(migration_paths(database), version) do |migration| | ||
ENV["SCOPE"].blank? || (ENV["SCOPE"] == migration.scope) | ||
end | ||
Database.dump(database) | ||
end | ||
end | ||
|
||
# Migrate up/down to a specific version | ||
def run(direction, database, version) | ||
Database.process(database) do | ||
ActiveRecord::Migrator.run(direction, ActiveRecord::Migrator.migrations_paths, version) | ||
Database.process(database, true) do | ||
ActiveRecord::Migrator.run(direction, migration_paths(database), version) | ||
Database.dump(database) | ||
end | ||
end | ||
|
||
# rollback latest migration `step` number of times | ||
def rollback(database, step = 1) | ||
Database.process(database) do | ||
ActiveRecord::Migrator.rollback(ActiveRecord::Migrator.migrations_paths, step) | ||
Database.process(database, true) do | ||
ActiveRecord::Migrator.rollback(migration_paths(database), step) | ||
Database.dump(database) | ||
end | ||
end | ||
|
||
private | ||
|
||
def migration_paths(tenant) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
paths = [Apartment.migration_path] | ||
paths << "#{Apartment.migration_path}/../#{tenant}" if File.exists?("#{Apartment.migration_path}/../#{tenant}") | ||
paths | ||
end | ||
|
||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I Don't think I agree with this default. Can you explain why you think Apartment shouldn't migrate the tenants by default?
I'm just trying to look at things from a new user's perspective. Someone that doesn't know Apartment that well would have to know to enable this, rather than it just working out of the box. More advanced users can disable it to their liking, but I'd like to err on the side of simplicity