Fix bug where aggregate operations could not change type #1318
Conversation
| Values: [][]interface{}{ | ||
| { | ||
| time.Date(1971, 1, 1, 0, 0, 20, 0, time.UTC), | ||
| 1.0, |
There was a problem hiding this comment.
What would have happened previously? It would have been a int?
There was a problem hiding this comment.
Or does it have to do with the type of value changing.
There was a problem hiding this comment.
Or is it something else entirely. I think I might be confused about what this fixes.
There was a problem hiding this comment.
Previously it would have errored and returned no value.
There was a problem hiding this comment.
To be more clear, the result here will always be an int since count returns an int. That isn't the type that is changing. Rather the type of the aggregate function used to perform the count (yes it is typed) wasn't changing. So in this test the first window is empty and so we choose a default type of float, but on the second window when there are actual values that are ints, we needed to change the aggregator function to be the int type function. Previous to this fix it would have logged an error about the types and returned no data for the count operation.
nathanielc
force-pushed
the
nc-issue#1271
branch
from
636b1cf to
7dfb18d
Compare
Fix bug where aggregate operations could not change type
Fixes #1271