Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding launchfiles, sample rosbags and improving documentation #19

Merged
merged 21 commits into from
Jul 6, 2021
Merged

Adding launchfiles, sample rosbags and improving documentation #19

merged 21 commits into from
Jul 6, 2021

Conversation

leandropineda
Copy link
Member

Changes

  • Added description on all configuration file parameters
  • Added ROS2 launchfile for running the node
  • Added sample folder with a demo rosbag and a proper configuration file to match bag data
  • Added a launchfile for playing demo rosbag and node
  • Fixed unstable test (see latest pipeline output)
  • Fixed velocity reporting (replaced angle by angular)
  • Fixed timestamp update. Now it's updated each time the message is sent.

@leandropineda
Copy link
Member Author

@miguelgarcia ready for review!

Copy link
Member

@miguelgarcia miguelgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just small suggestions

massrobotics_amr_sender_py/sample/README.md Outdated Show resolved Hide resolved
massrobotics_amr_sender_py/sample/README.md Outdated Show resolved Hide resolved
massrobotics_amr_sender_py/sample/README.md Outdated Show resolved Hide resolved
@leandropineda leandropineda merged commit e76f146 into inorbit-ai:foxy-devel Jul 6, 2021
@leandropineda leandropineda linked an issue Jul 6, 2021 that may be closed by this pull request
@leandropineda leandropineda deleted the launchfiles-and-samples branch June 6, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add launchfile with example config
2 participants