Adding bits for first release #7
Conversation
|
@adamantivm @miguelgarcia Ready for review. I added some minor changes and did some tests on the tooling needed for first time release: http://wiki.ros.org/bloom/Tutorials/FirstTimeRelease#bloom.2FTutorials.2FPrepareUpstream.Preparing_the_Upstream_Repository After merging, I'll do the steps described on the section I just added |
leandropineda
changed the title
massrobotics_amr_sender_py/README.md
Outdated
| @@ -33,3 +33,27 @@ On you local workspace: | |||
| colcon test --packages-select massrobotics_amr_sender | |||
| colcon test-result --verbose | |||
| ``` | |||
|
|
|||
| ## Releasing a new version | |||
There was a problem hiding this comment.
My bad memory tells me this is something done by the maintainers, so it's not very useful to mix with usage documentation. It should probably go elsewhere.
Could you do me a favor and check other packages to see if it's common to include the release instructions in the package README?
There was a problem hiding this comment.
TBH most of the packages I've seen don't have a README, but I agree that this shouldn't be here. Actually, these are notes I took while testing commands
There was a problem hiding this comment.
Perhaps a separate file, like MAINTAINER_README.md ? I agree the instructions shouldn't be in the README, but I wouldn't just throw them away since they are useful indeed
Changes
setup.pyfile version is now obtained frompackage.xmlfileREADME.mdrelease instructionsvscodeworkspace fileNote
The proper release will be done from
foxy-develbranch, after merging this PR.