OTP.byte_secret: do not mutate state

interestinall · Feb 4, 2021 · ee827b4 · ee827b4
1 parent e4ddcf3
commit ee827b4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/pyotp/otp.py b/src/pyotp/otp.py
@@ -37,10 +37,11 @@ def generate_otp(self, input: int) -> str:
         return str_code
 
     def byte_secret(self) -> bytes:
-        missing_padding = len(self.secret) % 8
+        secret = self.secret
+        missing_padding = len(secret) % 8
         if missing_padding != 0:
-            self.secret += '=' * (8 - missing_padding)
-        return base64.b32decode(self.secret, casefold=True)
+            secret += '=' * (8 - missing_padding)
+        return base64.b32decode(secret, casefold=True)
 
     @staticmethod
     def int_to_bytestring(i: int, padding: int = 8) -> bytes:

diff --git a/test.py b/test.py
@@ -118,6 +118,11 @@ def test_provisioning_uri(self):
             ).provisioning_uri()
         )
 
+        code = pyotp.totp.TOTP("S46SQCPPTCNPROMHWYBDCTBZXV")
+        self.assertEqual(code.provisioning_uri(), "otpauth://totp/Secret?secret=S46SQCPPTCNPROMHWYBDCTBZXV")
+        code.verify("123456")
+        self.assertEqual(code.provisioning_uri(), "otpauth://totp/Secret?secret=S46SQCPPTCNPROMHWYBDCTBZXV")
+
     def test_other_secret(self):
         hotp = pyotp.HOTP(
             'N3OVNIBRERIO5OHGVCMDGS4V4RJ3AUZOUN34J6FRM4P6JIFCG3ZA')