Fixed ics.get_error_messages() (#176)

* updated debugging stuff for linux * Fixed issue #175. GIL issue on error.
intrepidcs · Feb 23, 2024 · c07589f · c07589f
1 parent c676c95
commit c07589f
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/.vscode/extensions.json b/.vscode/extensions.json
@@ -0,0 +1,9 @@
+{
+    "recommendations": [
+        "ms-python.python",
+        "charliermarsh.ruff",
+        "mikoz.black-py",
+        "xaver.clang-format",
+        "webfreak.debug"
+    ]
+}
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -41,7 +41,7 @@
             "name": "Python: Debug icsdebug.py",
             "type": "debugpy",
             "request": "launch",
-            "program": "src\\icsdebug.py",
+            "program": "src/icsdebug.py",
             "console": "integratedTerminal"
         },
         {
@@ -50,5 +50,11 @@
             "request": "attach",
             "pid": "${command:pickProcess}",
         }
+        {
+            "name": "Debugger Attach lldb",
+            "type": "lldb",
+            "request": "attach",
+            "pid": "${command:pickProcess}",
+        }
     ]
 }
diff --git a/src/methods.cpp b/src/methods.cpp
@@ -1150,8 +1150,8 @@ PyObject* meth_get_error_messages(PyObject* self, PyObject* args)
         ice::Function<int __stdcall(ICS_HANDLE, int*, int*)> icsneoGetErrorMessages(lib, "icsneoGetErrorMessages");
         Py_BEGIN_ALLOW_THREADS;
         if (!icsneoGetErrorMessages(handle, errors, &error_count)) {
-            Py_UNBLOCK_THREADS return set_ics_exception(exception_runtime_error(),
-                                                        "icsneoScriptGetScriptStatusEx() Failed");
+            Py_BLOCK_THREADS return set_ics_exception(exception_runtime_error(),
+                                                        "icsneoGetErrorMessages() Failed");
         }
         Py_END_ALLOW_THREADS;
         ice::Function<int __stdcall(int, char*, char*, int*, int*, int*, int*)> icsneoGetErrorInfo(