Skip to content
This repository has been archived by the owner on Jul 7, 2020. It is now read-only.

[DnsDock] Fix for image name including forward slash #115

Merged
merged 2 commits into from
May 24, 2016

Conversation

wodor
Copy link

@wodor wodor commented May 24, 2016

If docker-compose.yml has an image name that contains forward slash like

web:
    image: someone/image

It results in web.someone/image.docker DNS address and it does not work
/ seems to be an issue here

This PR enables removing everything before slash in container name.
After this change dock-cli ps shows web.image.docker.

@andytson-inviqa
Copy link

underscore doesn't work very well in DNS domains

@sroze
Copy link
Contributor

sroze commented May 24, 2016

Thanks for this PR! Actually, you should remove the slash and everything before as it's dnsdock's strategy.

@sroze
Copy link
Contributor

sroze commented May 24, 2016

Thank you @wodor!

@sroze sroze merged commit e73e2f8 into inviqa:master May 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants