Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(radio-group): add helper and error text to the ionic theme #30271

Open
wants to merge 7 commits into
base: next
Choose a base branch
from
Open

feat(radio-group): add helper and error text to the ionic theme #30271

wants to merge 7 commits into from

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Mar 19, 2025 •
edited
Loading

Issue number: internal

What is the new behavior?

  • Adds the common stylesheet for the shared styles
  • Adds design for helper and error text to the radio group for the ionic theme.
  • Updates tests to add screenshots for ionic theme

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

@vercel Vercel
Copy link

vercel bot commented Mar 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 7:32pm

@github-actions github-actions bot added the package: core @ionic/core package label Mar 19, 2025
@brandyscarney brandyscarney changed the base branch from FW-6389 to next March 19, 2025 19:42
@brandyscarney brandyscarney changed the base branch from next to FW-6389 March 19, 2025 19:44
@brandyscarney brandyscarney changed the base branch from FW-6389 to next March 20, 2025 15:04
@brandyscarney brandyscarney marked this pull request as ready for review March 20, 2025 20:15
@brandyscarney brandyscarney requested a review from a team as a code owner March 20, 2025 20:15
@brandyscarney brandyscarney requested a review from gnbm March 20, 2025 20:15
@brandyscarney brandyscarney requested a review from thetaPC March 24, 2025 19:27
thetaPC
thetaPC approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC thetaPC approved these changes

@BenOsodrac BenOsodrac BenOsodrac approved these changes

@gnbm gnbm Awaiting requested review from gnbm gnbm is a code owner automatically assigned from ionic-team/framework

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandyscarney @thetaPC @BenOsodrac