Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(select): add helper and error text to the ionic theme #30280

Merged
merged 9 commits into from
Mar 25, 2025
Merged

feat(select): add helper and error text to the ionic theme #30280

merged 9 commits into from
Mar 25, 2025
+66 −12

Conversation

brandyscarney
Copy link
Member

Issue number: internal

What is the new behavior?

  • Adds design for helper and error text to the select for the ionic theme.
  • Updates tests to add screenshots for ionic theme

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview

Sorry, something went wrong.

@brandyscarney
feat(select): add helper and error text to the ionic theme

Verified

This commit was signed with the committer’s verified signature.
brandyscarney Brandy Smith
SSH Key Fingerprint: 2YWmM9lxpAinS5q/DupTwV/sKf8t6Nv0ITVyNSH12yE
Verified
Learn about vigilant mode
bba7dbf
@brandyscarney
chore(): add updated snapshots

Verified

This commit was signed with the committer’s verified signature.
brandyscarney Brandy Smith
SSH Key Fingerprint: 2YWmM9lxpAinS5q/DupTwV/sKf8t6Nv0ITVyNSH12yE
Verified
Learn about vigilant mode
24e58bb
@brandyscarney
test(select): add fill screenshots for ionic theme

Verified

This commit was signed with the committer’s verified signature.
brandyscarney Brandy Smith
SSH Key Fingerprint: 2YWmM9lxpAinS5q/DupTwV/sKf8t6Nv0ITVyNSH12yE
Verified
Learn about vigilant mode
Loading
Loading status checks…
865bd5f
@vercel Vercel
Copy link

vercel bot commented Mar 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 2:51pm

@github-actions github-actions bot added the package: core @ionic/core package label Mar 20, 2025
@brandyscarney
Merge branch 'next' into FW-6389-select

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
1805125
@brandyscarney brandyscarney marked this pull request as ready for review March 20, 2025 20:00
@brandyscarney brandyscarney requested a review from a team as a code owner March 20, 2025 20:00
@brandyscarney brandyscarney requested a review from ShaneK March 20, 2025 20:00
@brandyscarney
fix(select): add margin top to select bottom

Verified

This commit was signed with the committer’s verified signature.
brandyscarney Brandy Smith
SSH Key Fingerprint: 2YWmM9lxpAinS5q/DupTwV/sKf8t6Nv0ITVyNSH12yE
Verified
Learn about vigilant mode
Loading
Loading status checks…
162c57b
@brandyscarney
chore(): add updated snapshots

Verified

This commit was signed with the committer’s verified signature.
brandyscarney Brandy Smith
SSH Key Fingerprint: 2YWmM9lxpAinS5q/DupTwV/sKf8t6Nv0ITVyNSH12yE
Verified
Learn about vigilant mode
Loading
Loading status checks…
2b12de1
thetaPC
thetaPC approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

brandyscarney and others added 2 commits March 24, 2025 15:17
@brandyscarney
fix(select): use padding for bottom content

Verified

This commit was signed with the committer’s verified signature.
brandyscarney Brandy Smith
SSH Key Fingerprint: 2YWmM9lxpAinS5q/DupTwV/sKf8t6Nv0ITVyNSH12yE
Verified
Learn about vigilant mode
Loading
Loading status checks…
a8bf18d
@brandyscarney
Merge branch 'next' into FW-6389-select

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
4665f5f
thetaPC
thetaPC approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandyscarney
Merge branch 'next' into FW-6389-select

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
d0e1735
@brandyscarney brandyscarney merged commit 7f24ba0 into next Mar 25, 2025
48 checks passed
@brandyscarney brandyscarney deleted the FW-6389-select branch March 25, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetaPC thetaPC

@BenOsodrac BenOsodrac

@ShaneK ShaneK

Assignees
No one assigned
Labels
package: core @ionic/core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brandyscarney @thetaPC @BenOsodrac