fix(sheet): change default visibility to original footer when expandToScroll is false #30310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kumibrr
changed the title
|
Thank you for submitting the PR! However, we require issues to be submitted first and then tied to the PR for us to proceed with reviewing. |
3 tasks
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #30315
What is the current behavior?
When
expandToScroll = false, the original footer is swapped by a cloned one to avoid animation issues.But if the original footer has some eventListeners, they won't work on the cloned footer.
What is the new behavior?
Footer visibility is the original by default, and the visibility will swap to the cloned one when the animation starts, and will be swapped back to the original when the animation ends
Does this introduce a breaking change?
Other information
Screen.Recording.2025-03-26.at.19.13.47.mov
Screen.Recording.2025-03-26.at.19.14.32.mov
EDIT: The button in the videos "jump" from left to right, this is caused by another issue I discovered yesterday (stylesheets not being applied), but it's quite tricky to solve. I've opened an issue for that #30312