fix(divider): remove safe areas from horizontal padding #30311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
approved these changes
Mar 28, 2025
BenOsodrac
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The horizontal padding of the divider component was being calculated taking into account safe areas.
However, since this component can be placed inside other components that already take these areas into account, this is not necessary.
What is the new behavior?
Does this introduce a breaking change?
Other information
Confirmed with design: the new divider component’s main use case is to be used inside ion-content (or one of it’s children). As such, the responsibility of taking into account safe areas will fall on the developer (as it’s already stated in the documentation). This means, the divider component itself will not account for the safe areas for its' specific padding.
The default spacing also changed from
xxsmalltomedium