Improve URL handling is post creator

iparks99 · Oct 8, 2023 · 6a99a17 · 6a99a17
1 parent 900fb5a
commit 6a99a17
Show file tree

Hide file tree

Showing 7 changed files with 38 additions and 3 deletions.
diff --git a/lib/community/pages/create_post_page.dart b/lib/community/pages/create_post_page.dart
@@ -45,6 +45,7 @@ class _CreatePostPageState extends State<CreatePostPage> {
   bool imageUploading = false;
   bool postImageUploading = false;
   String url = "";
+  String? urlError;
   DraftPost newDraftPost = DraftPost();
 
   final TextEditingController _bodyTextController = TextEditingController();
@@ -58,13 +59,14 @@ class _CreatePostPageState extends State<CreatePostPage> {
     super.initState();
 
     _titleTextController.addListener(() {
-      if (_titleTextController.text.isEmpty && !isSubmitButtonDisabled) setState(() => isSubmitButtonDisabled = true);
-      if (_titleTextController.text.isNotEmpty && isSubmitButtonDisabled) setState(() => isSubmitButtonDisabled = false);
+      _validateSubmission();
 
       widget.onUpdateDraft?.call(newDraftPost..title = _titleTextController.text);
     });
 
     _urlTextController.addListener(() {
+      _validateSubmission();
+
       url = _urlTextController.text;
       debounce(const Duration(milliseconds: 1000), _updatePreview, [url]);
 
@@ -194,6 +196,7 @@ class _CreatePostPageState extends State<CreatePostPage> {
                           controller: _urlTextController,
                           decoration: InputDecoration(
                               hintText: AppLocalizations.of(context)!.postURL,
+                              errorText: urlError,
                               suffixIcon: IconButton(
                                   onPressed: () {
                                     if (!postImageUploading) {
@@ -343,6 +346,28 @@ class _CreatePostPageState extends State<CreatePostPage> {
       setState(() {});
     }
   }
+
+  void _validateSubmission() {
+    final Uri? parsedUrl = Uri.tryParse(_urlTextController.text);
+
+    if (isSubmitButtonDisabled) {
+      // It's disabled, check if we can enable it.
+      if (_titleTextController.text.isNotEmpty && parsedUrl != null) {
+        setState(() {
+          isSubmitButtonDisabled = false;
+          urlError = null;
+        });
+      }
+    } else {
+      // It's enabled, check if we need to disable it.
+      if (_titleTextController.text.isEmpty || parsedUrl == null) {
+        setState(() {
+          isSubmitButtonDisabled = true;
+          urlError = parsedUrl == null ? AppLocalizations.of(context)!.notValidUrl : null;
+        });
+      }
+    }
+  }
 }
 
 class DraftPost {

diff --git a/lib/l10n/app_en.arb b/lib/l10n/app_en.arb
@@ -85,6 +85,7 @@
   "changeSort": "Change Sort",
   "postTitle": "Title",
   "postURL": "URL",
+  "notValidUrl": "Not a valid URL",
   "postBody": "Post Body",
   "postTogglePreview": "Toggle Preview",
   "postUploadImageError": "Error when uploading image",

diff --git a/lib/l10n/app_es.arb b/lib/l10n/app_es.arb
@@ -85,6 +85,7 @@
   "changeSort": "Cambiar orden",
   "postTitle": "Título",
   "postURL": "URL",
+  "notValidUrl": "Not a valid URL",
   "postBody": "Cuerpo de la publicación",
   "postTogglePreview": "Cambiar vista previa",
   "postUploadImageError": "Error al subir imagen",

diff --git a/lib/l10n/app_fi.arb b/lib/l10n/app_fi.arb
@@ -83,6 +83,7 @@
   "dismissRead": "Dismiss Read",
   "postTitle": "Title",
   "postURL": "URL",
+  "notValidUrl": "Not a valid URL",
   "postBody": "Post Body",
   "postTogglePreview": "Toggle Preview",
   "postUploadImageError": "Error when uploading image",

diff --git a/lib/l10n/app_pl.arb b/lib/l10n/app_pl.arb
@@ -85,6 +85,7 @@
   "changeSort": "Zmiana sortowania",
   "postTitle": "Tytuł",
   "postURL": "Link",
+  "notValidUrl": "Not a valid URL",
   "postBody": "Treść",
   "postTogglePreview": "Przełącz podgląd",
   "postUploadImageError": "Wystąpił błąd podczas przesyłania obrazu",

diff --git a/lib/l10n/app_sv.arb b/lib/l10n/app_sv.arb
@@ -83,6 +83,7 @@
   "dismissRead": "Dismiss Read",
   "postTitle": "Title",
   "postURL": "URL",
+  "notValidUrl": "Not a valid URL",
   "postBody": "Post Body",
   "postTogglePreview": "Toggle Preview",
   "postUploadImageError": "Error when uploading image",

diff --git a/lib/utils/image.dart b/lib/utils/image.dart
@@ -20,7 +20,12 @@ String generateRandomHeroString({int? len}) {
 bool isImageUrl(String url) {
   final imageExtensions = ['.png', '.jpg', '.jpeg', '.gif', '.bmp', '.svg', '.webp'];
 
-  final uri = Uri.parse(url);
+  Uri uri;
+  try {
+    uri = Uri.parse(url);
+  } catch (e) {
+    return false;
+  }
   final path = uri.path.toLowerCase();
 
   for (final extension in imageExtensions) {