Use constructor injection in DataSourceInitializer

Closes spring-projectsgh-7973
ipaste · Jan 17, 2017 · 19e117c · 19e117c
1 parent 8d67a2f
commit 19e117c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 11 deletions.
diff --git a/...rc/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceAutoConfiguration.java b/...rc/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceAutoConfiguration.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2016 the original author or authors.
+ * Copyright 2012-2017 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -40,6 +40,7 @@
 import org.springframework.boot.autoconfigure.jdbc.DataSourceInitializerPostProcessor.Registrar;
 import org.springframework.boot.autoconfigure.jdbc.metadata.DataSourcePoolMetadataProvidersConfiguration;
 import org.springframework.boot.context.properties.EnableConfigurationProperties;
+import org.springframework.context.ApplicationContext;
 import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Condition;
 import org.springframework.context.annotation.ConditionContext;
@@ -57,6 +58,7 @@
  * @author Dave Syer
  * @author Phillip Webb
  * @author Stephane Nicoll
+ * @author Kazuki Shimizu
  */
 @Configuration
 @ConditionalOnClass({ DataSource.class, EmbeddedDatabaseType.class })
@@ -69,8 +71,9 @@ public class DataSourceAutoConfiguration {
 
 	@Bean
 	@ConditionalOnMissingBean
-	public DataSourceInitializer dataSourceInitializer() {
-		return new DataSourceInitializer();
+	public DataSourceInitializer dataSourceInitializer(
+		DataSourceProperties properties, ApplicationContext applicationContext) {
+		return new DataSourceInitializer(properties, applicationContext);
 	}
 
 	/**

diff --git a/...gure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceInitializer.java b/...gure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceInitializer.java
@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2016 the original author or authors.
+ * Copyright 2012-2017 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -26,10 +26,9 @@
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.context.config.ResourceNotFoundException;
+import org.springframework.context.ApplicationContext;
 import org.springframework.context.ApplicationListener;
-import org.springframework.context.ConfigurableApplicationContext;
 import org.springframework.core.io.Resource;
 import org.springframework.jdbc.config.SortedResourcesFactoryBean;
 import org.springframework.jdbc.datasource.init.DatabasePopulatorUtils;
@@ -45,23 +44,27 @@
  * @author Phillip Webb
  * @author Eddú Meléndez
  * @author Stephane Nicoll
+ * @author Kazuki Shimizu
  * @since 1.1.0
  * @see DataSourceAutoConfiguration
  */
 class DataSourceInitializer implements ApplicationListener<DataSourceInitializedEvent> {
 
 	private static final Log logger = LogFactory.getLog(DataSourceInitializer.class);
 
-	@Autowired
-	private ConfigurableApplicationContext applicationContext;
+	private final DataSourceProperties properties;
 
-	private DataSource dataSource;
+	private final ApplicationContext applicationContext;
 
-	@Autowired
-	private DataSourceProperties properties;
+	private DataSource dataSource;
 
 	private boolean initialized = false;
 
+	DataSourceInitializer(DataSourceProperties properties, ApplicationContext applicationContext) {
+		this.properties = properties;
+		this.applicationContext = applicationContext;
+	}
+
 	@PostConstruct
 	public void init() {
 		if (!this.properties.isInitialize()) {