Skip to content

Commit

Permalink
Fix typos (janhq#2714)
Browse files Browse the repository at this point in the history
  • Loading branch information
deining authored Apr 15, 2024
1 parent 1619478 commit 81e8889
Show file tree
Hide file tree
Showing 18 changed files with 27 additions and 27 deletions.
4 changes: 2 additions & 2 deletions charts/server/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ common:
securityContext: {}

service:
extenalLabel: {}
externalLabel: {}
type: ClusterIP
port: 1337
targetPort: 1337
Expand Down Expand Up @@ -193,7 +193,7 @@ common:
securityContext: {}

service:
extenalLabel: {}
externalLabel: {}
type: ClusterIP
port: 3000
targetPort: 3000
Expand Down
2 changes: 1 addition & 1 deletion core/src/browser/core.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ const joinPath: (paths: string[]) => Promise<string> = (paths) =>
globalThis.core.api?.joinPath(paths)

/**
* Retrive the basename from an url.
* Retrieve the basename from an url.
* @param path - The path to retrieve.
* @returns {Promise<string>} A promise that resolves with the basename.
*/
Expand Down
2 changes: 1 addition & 1 deletion core/src/node/helper/resource.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { log } from './logger'

export const getSystemResourceInfo = async (): Promise<SystemResourceInfo> => {
const cpu = await physicalCpuCount()
log(`[NITRO]::CPU informations - ${cpu}`)
log(`[NITRO]::CPU information - ${cpu}`)

return {
numCpuPhysicalCore: cpu,
Expand Down
2 changes: 1 addition & 1 deletion electron/utils/selectedText.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export const getSelectedText = async () => {

/**
* Registers a global shortcut of `accelerator`. The `callback` is called
* with the selected text when the registered shorcut is pressed by the user
* with the selected text when the registered shortcut is pressed by the user
*
* Returns `true` if the shortcut was registered successfully
*/
Expand Down
2 changes: 1 addition & 1 deletion electron/utils/setup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { app } from 'electron'
export const setupCore = async () => {
// Setup core api for main process
global.core = {
// Define appPath function for app to retrieve app path globaly
// Define appPath function for app to retrieve app path globally
appPath: () => app.getPath('userData'),
}
}
12 changes: 6 additions & 6 deletions extensions/inference-nitro-extension/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export default class JanInferenceNitroExtension extends LocalOAIEngine {
/**
* The interval id for the health check. Used to stop the health check.
*/
private getNitroProcesHealthIntervalId: NodeJS.Timeout | undefined = undefined
private getNitroProcessHealthIntervalId: NodeJS.Timeout | undefined = undefined

/**
* Tracking the current state of nitro process.
Expand All @@ -65,7 +65,7 @@ export default class JanInferenceNitroExtension extends LocalOAIEngine {
this.inferenceUrl = `${window.core?.api?.baseApiUrl}/v1/chat/completions`
}

this.getNitroProcesHealthIntervalId = setInterval(
this.getNitroProcessHealthIntervalId = setInterval(
() => this.periodicallyGetNitroHealth(),
JanInferenceNitroExtension._intervalHealthCheck
)
Expand Down Expand Up @@ -95,7 +95,7 @@ export default class JanInferenceNitroExtension extends LocalOAIEngine {

override loadModel(model: Model): Promise<void> {
if (model.engine !== this.provider) return Promise.resolve()
this.getNitroProcesHealthIntervalId = setInterval(
this.getNitroProcessHealthIntervalId = setInterval(
() => this.periodicallyGetNitroHealth(),
JanInferenceNitroExtension._intervalHealthCheck
)
Expand All @@ -106,9 +106,9 @@ export default class JanInferenceNitroExtension extends LocalOAIEngine {
if (model?.engine && model.engine !== this.provider) return

// stop the periocally health check
if (this.getNitroProcesHealthIntervalId) {
clearInterval(this.getNitroProcesHealthIntervalId)
this.getNitroProcesHealthIntervalId = undefined
if (this.getNitroProcessHealthIntervalId) {
clearInterval(this.getNitroProcessHealthIntervalId)
this.getNitroProcessHealthIntervalId = undefined
}
return super.unloadModel(model)
}
Expand Down
2 changes: 1 addition & 1 deletion extensions/monitoring-extension/src/node/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export const getCurrentLoad = () =>
})

/**
* This will retrive GPU informations and persist settings.json
* This will retrieve GPU information and persist settings.json
* Will be called when the extension is loaded to turn on GPU acceleration if supported
*/
export const updateNvidiaInfo = async () => {
Expand Down
2 changes: 1 addition & 1 deletion extensions/monitoring-extension/src/node/logger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export class FileLogger extends Logger {
daysToKeep?: number | undefined
): void {
// clear existing timeout
// incase we rerun it with different values
// in case we rerun it with different values
if (this.timeout) clearTimeout(this.timeout)
this.timeout = undefined

Expand Down
2 changes: 1 addition & 1 deletion server/helpers/setup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export async function setup() {
if (!existsSync(appDir)) mkdirSync(appDir)
//@ts-ignore
global.core = {
// Define appPath function for app to retrieve app path globaly
// Define appPath function for app to retrieve app path globally
appPath: () => appDir,
}
init({
Expand Down
2 changes: 1 addition & 1 deletion specs/adrs/adr-001-jan-deployable-cloud-native.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

* This ADR aims to outline design decisions for deploying Jan in cloud native environments such as: Runpod, AWS, Azure, GCP in a fast and simple way.
* The current code-base should not change too much.
* The current plugins must be reusable across enviroments (Desktop, Cloud-native).
* The current plugins must be reusable across environments (Desktop, Cloud-native).


### Key Design Decisions
Expand Down
4 changes: 2 additions & 2 deletions specs/adrs/adr-003-jan-plugins.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ Modular Architecture w/ Plugins:

- Jan will have an architecture similar to VSCode or k8Lens
- "Desktop Application" whose functionality can be extended thru plugins
- Jan's architecture will need to accomodate plugins for (a) Persistence(b) IAM(c) Teams and RBAC(d) Policy engines(e) "Apps" (i.e. higher-order business logic)(f) Themes (UI)
- Nitro's architecture will need to accomodate plugins for different "model backends"(a) llama.cpp(b) rkwk (and others)(c) 3rd-party AIs
- Jan's architecture will need to accommodate plugins for (a) Persistence(b) IAM(c) Teams and RBAC(d) Policy engines(e) "Apps" (i.e. higher-order business logic)(f) Themes (UI)
- Nitro's architecture will need to accommodate plugins for different "model backends"(a) llama.cpp(b) rkwk (and others)(c) 3rd-party AIs

## Decision

Expand Down
2 changes: 1 addition & 1 deletion specs/adrs/adr-008-Extensible-Jan-with-Docker.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Proposed
## Context

What is the issue that we're seeing that is motivating this decision or change?
- The A.I world is moving fast with multiple runtime/ prebaked environment. We or the builder cannot cover just everything but rather we should adopt it and facillitate it as much as possible within Jan.
- The A.I world is moving fast with multiple runtime/ prebaked environment. We or the builder cannot cover just everything but rather we should adopt it and facilitate it as much as possible within Jan.
- For `Run your own A.I`: Builder can build app on Jan (NodeJS env) and connect to external endpoint which serves the real A.I
- e.g 1: Nitro acting as proxy to `triton-inference-server` running within a Docker container controlled by Jan app
- e.g 2: Original models can be in many formats (pytorch, paddlepaddle). In order to run it with the most optimized version locally, there must be a step to transpile the model ([Ollama import model](https://github.com/jmorganca/ollama/blob/main/docs/import.md), Tensorrt). Btw Jan can prebuilt it and let user pull but later
Expand Down
2 changes: 1 addition & 1 deletion web/app/error.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export default function Error({
>
contact us
</a>{' '}
if the problem presists.
if the problem persists.
</p>
<div
className="mt-5 w-full rounded border border-red-400 bg-red-100 px-4 py-3 text-red-700"
Expand Down
6 changes: 3 additions & 3 deletions web/constants/tagType.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ export enum UsecaseTag {
UsecaseDefault = 'UsecaseDefault',
}

export enum MiscellanousTag {
MiscellanousDefault = 'MiscellanousDefault',
export enum MiscellaneousTag {
MiscellaneousDefault = 'MiscellaneousDefault',
}

export type TagType =
Expand All @@ -59,4 +59,4 @@ export type TagType =
| NumOfBit
| RamRequired
| UsecaseTag
| MiscellanousTag
| MiscellaneousTag
2 changes: 1 addition & 1 deletion web/containers/DropdownListSidebar/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ const DropdownListSidebar = ({
...model?.parameters,
...model?.settings,
}
// Update model paramter to the thread state
// Update model parameter to the thread state
setThreadModelParams(activeThread.id, modelParams)

// Update model parameter to the thread file
Expand Down
2 changes: 1 addition & 1 deletion web/hooks/useGetSystemResources.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ export default function useGetSystemResources() {

return {
/**
* Fetch resource informations once
* Fetch resource information once
*/
getSystemResources,
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const HuggingFaceConvertingErrorModal = () => {
</div>
<div className="flex flex-col items-center justify-center gap-1">
<p className="text-center">
An error occured while {conversionStatus} model {repoData.id}.
An error occurred while {conversionStatus} model {repoData.id}.
</p>
<p>Please close this modal and try again.</p>
</div>
Expand Down
2 changes: 1 addition & 1 deletion web/screens/ExploreModels/HuggingFaceSearchModal/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const HuggingFaceSearchModal = () => {
return (
<>
<div className="flex flex-col items-center justify-center gap-1">
<p className="text-2xl font-bold">Hugging Face Convertor</p>
<p className="text-2xl font-bold">Hugging Face Converter</p>
<p className="text-gray-500">Type the repository id below</p>
</div>
<Input
Expand Down

0 comments on commit 81e8889

Please sign in to comment.