Skip to content

Commit

Permalink
GEODE-7647: Removing unused code from GMSJoinLeave
Browse files Browse the repository at this point in the history
Removing some code which set the coord and coordIsNoob local variables but
never used them.
  • Loading branch information
upthewaterspout authored Jan 6, 2020
1 parent b32ff42 commit 13362a0
Showing 1 changed file with 0 additions and 21 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1223,27 +1223,6 @@ boolean findCoordinator() throws MemberStartupException {
}
state.possibleCoordinator = oldest;
}
ID coord = null;
boolean coordIsNoob = true;
for (; it.hasNext();) {
ID mbr = it.next();
if (!state.alreadyTried.contains(mbr)) {
boolean mbrIsNoob = (mbr.getVmViewId() < 0);
if (mbrIsNoob) {
// member has not yet joined
if (coordIsNoob && (coord == null
|| services.getMemberFactory().getComparator().compare(coord, mbr) > 0)) {
coord = mbr;
}
} else {
// member has already joined
if (coordIsNoob || mbr.getVmViewId() > coord.getVmViewId()) {
coord = mbr;
coordIsNoob = false;
}
}
}
}
logger.info("findCoordinator chose {} out of these possible coordinators: {}",
state.possibleCoordinator, possibleCoordinators);
return true;
Expand Down

0 comments on commit 13362a0

Please sign in to comment.