lint: mega cleanup

internal/db/db_sqlite.go

@@ -13,7 +13,7 @@ import (
 	"ariga.io/atlas/sql/migrate"
 	aschema "ariga.io/atlas/sql/schema"
 	asqlite "ariga.io/atlas/sql/sqlite"
-	_ "github.com/mattn/go-sqlite3"
+	_ "github.com/mattn/go-sqlite3" // sqlite driver
 )
 
 var (
@@ -269,7 +269,9 @@ func (s *Sqlite) CreateUserWithPublicKey(ctx context.Context, publickey *snips.P
 	if err != nil {
 		return nil, err
 	}
-	defer tx.Rollback()
+	defer func() {
+		_ = tx.Rollback()
+	}()
 
 	user := &snips.User{
 		ID:        id.New(),

internal/http/handlers.go

@@ -37,13 +37,18 @@ func IndexHandler(readme string, tmpl *template.Template) http.HandlerFunc {
 			"HTML":     md,
 		}
 
-		tmpl.ExecuteTemplate(w, "file.go.html", vars)
+		err = tmpl.ExecuteTemplate(w, "file.go.html", vars)
+		if err != nil {
+			log.Error().Err(err).Msg("unable to render template")
+			http.Error(w, "internal error", http.StatusInternalServerError)
+			return
+		}
 	}
 }
 
-func HealthHandler(w http.ResponseWriter, r *http.Request) {
+func HealthHandler(w http.ResponseWriter, _ *http.Request) {
 	w.WriteHeader(http.StatusOK)
-	w.Write([]byte("💚\n"))
+	_, _ = w.Write([]byte("💚\n"))
 }
 
 func FileHandler(cfg *config.Config, database db.DB, tmpl *template.Template) http.HandlerFunc {
@@ -81,7 +86,7 @@ func FileHandler(cfg *config.Config, database db.DB, tmpl *template.Template) ht
 		if ShouldSendRaw(r) {
 			w.Header().Set("Content-Type", "text/plain; charset=utf-8")
 			w.WriteHeader(http.StatusOK)
-			w.Write(file.Content)
+			_, _ = w.Write(file.Content)
 			return
 		}
 
@@ -132,7 +137,12 @@ func FileHandler(cfg *config.Config, database db.DB, tmpl *template.Template) ht
 			"Private":   file.Private,
 		}
 
-		tmpl.ExecuteTemplate(w, "file.go.html", vars)
+		err = tmpl.ExecuteTemplate(w, "file.go.html", vars)
+		if err != nil {
+			log.Error().Err(err).Msg("unable to render template")
+			http.Error(w, "internal error", http.StatusInternalServerError)
+			return
+		}
 	}
 }
 

internal/renderer/html.go

@@ -27,7 +27,7 @@ func ToSyntaxHighlightedHTML(fileType string, fileContent []byte) (template.HTML
 
 	chromaHTML := bytes.NewBuffer(nil)
 	// using fallback style because we'll use custom prebaked CSS
-	formatter.Format(chromaHTML, styles.Fallback, it)
+	err = formatter.Format(chromaHTML, styles.Fallback, it)
 	if err != nil {
 		return "", err
 	}

internal/renderer/term.go

@@ -33,7 +33,7 @@ func ToSyntaxHighlightedTerm(fileType string, fileContent []byte) (string, error
 	formatter := formatters.Get(TermFormatter)
 
 	chromaTerm := bytes.NewBuffer(nil)
-	formatter.Format(chromaTerm, style, it)
+	err = formatter.Format(chromaTerm, style, it)
 	if err != nil {
 		return "", err
 	}

internal/signer/signer.go

@@ -26,7 +26,7 @@ func (signer *Signer) SignURL(u url.URL) url.URL {
 	signature := signer.computeMac(u.String())
 
 	params := u.Query()
-	params.Set(SignatureQueryParameter, string(base64.URLEncoding.EncodeToString(signature)))
+	params.Set(SignatureQueryParameter, base64.URLEncoding.EncodeToString(signature))
 	u.RawQuery = params.Encode()
 
 	return u

internal/ssh/flags.go

@@ -71,9 +71,5 @@ func (df *DeleteFlags) Parse(out io.Writer, args []string) error {
 
 	df.BoolVar(&df.Force, "f", false, "force delete without confirmation")
 
-	if err := df.FlagSet.Parse(args); err != nil {
-		return err
-	}
-
-	return nil
+	return df.FlagSet.Parse(args)
 }

internal/ssh/middleware.go

@@ -78,7 +78,7 @@ func BlockIfNoPublicKey(next ssh.Handler) ssh.Handler {
 		if key := sesh.PublicKey(); key == nil {
 			wish.Println(sesh, "❌ Unfortunately snips.sh only supports public key authentication.")
 			wish.Println(sesh, "🔐 Please generate a keypair and try again.")
-			sesh.Exit(1)
+			_ = sesh.Exit(1)
 			return
 		}
 		next(sesh)

internal/ssh/middleware_test.go

@@ -58,7 +58,7 @@ func TestAssignUser(t *testing.T) {
 			},
 		})
 
-		session.Run("")
+		_ = session.Run("")
 	})
 
 	t.Run("matches existing user by fingerprint", func(t *testing.T) {
@@ -90,7 +90,7 @@ func TestAssignUser(t *testing.T) {
 			},
 		})
 
-		session.Run("")
+		_ = session.Run("")
 	})
 }
 

internal/ssh/session.go

@@ -52,7 +52,7 @@ func (sesh *UserSession) Error(err error, title string, f string, v ...interface
 	}
 
 	noti.Render(sesh)
-	sesh.Exit(1)
+	_ = sesh.Exit(1)
 }
 
 func (sesh *UserSession) IsPTY() bool {

internal/tui/tui.go

@@ -87,13 +87,13 @@ func (t TUI) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 
 			if len(t.viewStack) == 1 {
 				return t, tea.Quit
-			} else {
-				batchedCmds = append(batchedCmds, cmds.PopView())
-				if t.currentView() == views.Browser {
-					batchedCmds = append(batchedCmds, cmds.DeselectFile())
-				}
-				return t, tea.Batch(batchedCmds...)
 			}
+
+			batchedCmds = append(batchedCmds, cmds.PopView())
+			if t.currentView() == views.Browser {
+				batchedCmds = append(batchedCmds, cmds.DeselectFile())
+			}
+			return t, tea.Batch(batchedCmds...)
 		}
 
 		// otherwise, send key msgs to the current view

internal/tui/views/browser/browser.go

@@ -69,9 +69,9 @@ func (bwsr Browser) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 
 		if bwsr.options.focused {
 			return bwsr.handleOptionsNavigation(msg)
-		} else {
-			return bwsr.handleTableNavigation(msg)
 		}
+
+		return bwsr.handleTableNavigation(msg)
 	case tea.WindowSizeMsg:
 		bwsr.width, bwsr.height = msg.Width, msg.Height
 	case msgs.ReloadFiles:

internal/tui/views/browser/options.go

@@ -72,12 +72,12 @@ func (bwsr Browser) handleOptionsNavigation(msg tea.KeyMsg) (tea.Model, tea.Cmd)
 	return bwsr, nil
 }
 
-func (bwser Browser) getOptions() []option {
-	if len(bwser.files) == 0 {
+func (bwsr Browser) getOptions() []option {
+	if len(bwsr.files) == 0 {
 		return nil
 	}
 
-	file := bwser.files[bwser.table.index]
+	file := bwsr.files[bwsr.table.index]
 
 	var opts []option
 	for _, o := range options {

internal/tui/views/code/code.go

@@ -64,7 +64,7 @@ func (m *Code) renderContent(file *snips.File) string {
 		return ""
 	}
 
-	content, err := renderer.ToSyntaxHighlightedTerm(file.Type, []byte(file.Content))
+	content, err := renderer.ToSyntaxHighlightedTerm(file.Type, file.Content)
 	if err != nil {
 		log.Warn().Err(err).Msg("failed to render file as syntax highlighted")
 		content = string(file.Content)
@@ -90,7 +90,7 @@ func (m *Code) renderContent(file *snips.File) string {
 			Copy().
 			BorderRight(true).
 			MarginRight(1).
-			Render(fmt.Sprintf("%*d", int(maxDigits), i+1))
+			Render(fmt.Sprintf("%*d", maxDigits, i+1))
 
 		scrubbed := strings.ReplaceAll(line, "\t", "    ")
 		renderedLines = append(renderedLines, lineNumber+scrubbed)

internal/tui/views/prompt/cmds.go

@@ -7,15 +7,15 @@ import (
 
 func SetPromptKindCmd(pk Kind) tea.Cmd {
 	return func() tea.Msg {
-		return PromptKindSetMsg{
+		return KindSetMsg{
 			Kind: pk,
 		}
 	}
 }
 
 func SetPromptFeedbackCmd(feedback string, finished bool) tea.Cmd {
 	return func() tea.Msg {
-		return PromptFeedbackMsg{
+		return FeedbackMsg{
 			Feedback: feedback,
 			Finished: finished,
 		}
@@ -24,7 +24,7 @@ func SetPromptFeedbackCmd(feedback string, finished bool) tea.Cmd {
 
 func SetPromptErrorCmd(err error) tea.Cmd {
 	return func() tea.Msg {
-		return PromptFeedbackMsg{
+		return FeedbackMsg{
 			Feedback: styles.C(styles.Colors.Red, err.Error()),
 			Finished: false,
 		}

internal/tui/views/prompt/fileselect.go

@@ -36,7 +36,7 @@ func NewExtensionSelector(width int) list.Model {
 	items := []list.Item{}
 
 	for _, ext := range extensions {
-		items = append(items, selectorItem(ext))
+		items = append(items, ext)
 	}
 
 	li := list.New(items, selectorItemDelegate{}, width, 8)
@@ -68,7 +68,7 @@ func (d selectorItemDelegate) Spacing() int {
 	return 0
 }
 
-func (d selectorItemDelegate) Update(msg tea.Msg, m *list.Model) tea.Cmd {
+func (d selectorItemDelegate) Update(_ tea.Msg, _ *list.Model) tea.Cmd {
 	return nil
 }
 

internal/tui/views/prompt/msgs.go

@@ -1,10 +1,10 @@
 package prompt
 
-type PromptKindSetMsg struct {
+type KindSetMsg struct {
 	Kind Kind
 }
 
-type PromptFeedbackMsg struct {
+type FeedbackMsg struct {
 	Feedback string
 	Finished bool
 }

internal/tui/views/prompt/prompt.go

@@ -64,14 +64,13 @@ func (m Prompt) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
 
 	switch msg := msg.(type) {
 	case tea.KeyMsg:
-		switch msg.Type {
-		case tea.KeyEnter:
+		if msg.Type == tea.KeyEnter {
 			return m, m.handleSubmit()
 		}
-	case PromptFeedbackMsg:
+	case FeedbackMsg:
 		m.feedback = msg.Feedback
 		m.finished = msg.Finished
-	case PromptKindSetMsg:
+	case KindSetMsg:
 		m.pk = msg.Kind
 	case msgs.FileLoaded:
 		m.file = msg.File