Skip to content

Commit

Permalink
Merge pull request kubernetes#67700 from kad/fix-init-tc
Browse files Browse the repository at this point in the history
Automatic merge from submit-queue (batch tested with PRs 63757, 67698, 67712, 67494, 67700). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fix test case: invalid version should not trigger network operations

**What this PR does / why we need it**: current invalid version value in the test case triggers network operation to check it validity via `https://dl.k8s.io/`. Using incorrect semantic version will achieve same result of test case without possibility to trigger network connection.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #

**Special notes for your reviewer**:
@neolit123 

**Release note**:
```release-note
NONE
```
  • Loading branch information
Kubernetes Submit Queue authored Aug 22, 2018
2 parents c06b85e + 7f5b51f commit 0cb018f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cmd/kubeadm/test/cmd/init_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ func TestCmdInitKubernetesVersion(t *testing.T) {
expected bool
}{
{
name: "invalid version string is detected",
args: "--kubernetes-version=foobar",
name: "invalid semantic version string is detected",
args: "--kubernetes-version=v1.1",
expected: false,
},
{
Expand Down

0 comments on commit 0cb018f

Please sign in to comment.