Skip to content

Commit

Permalink
two more "shadowed locals"
Browse files Browse the repository at this point in the history
In these case, there seem to be no bug, but  simply renaming the "inner" variables improves code readability.
  • Loading branch information
softhack007 committed Apr 14, 2023
1 parent 996d041 commit 4a3bc48
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
6 changes: 3 additions & 3 deletions wled00/FX_fcn.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1181,12 +1181,12 @@ void WS2812FX::estimateCurrentAndLimitBri() {

uint32_t powerSum = 0;

for (uint8_t b = 0; b < busses.getNumBusses(); b++) {
Bus *bus = busses.getBus(b);
for (uint_fast8_t bNum = 0; bNum < busses.getNumBusses(); bNum++) {
Bus *bus = busses.getBus(bNum);
if (bus->getType() >= TYPE_NET_DDP_RGB) continue; //exclude non-physical network busses
uint16_t len = bus->getLength();
uint32_t busPowerSum = 0;
for (uint16_t i = 0; i < len; i++) { //sum up the usage of each LED
for (uint_fast16_t i = 0; i < len; i++) { //sum up the usage of each LED
uint32_t c = bus->getPixelColor(i);
byte r = R(c), g = G(c), b = B(c), w = W(c);

Expand Down
8 changes: 4 additions & 4 deletions wled00/pin_manager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -300,10 +300,10 @@ byte PinManagerClass::allocateLedc(byte channels)
if (ca >= channels) { //enough free channels
byte in = (i + 1) - ca;
for (byte j = 0; j < ca; j++) {
byte b = in + j;
byte by = b >> 3;
byte bi = b - 8*by;
bitWrite(ledcAlloc[by], bi, true);
byte bChan = in + j;
byte byChan = bChan >> 3;
byte biChan = bChan - 8*byChan;
bitWrite(ledcAlloc[byChan], biChan, true);
}
return in;
}
Expand Down

0 comments on commit 4a3bc48

Please sign in to comment.