Skip to content

Commit

Permalink
fixing rebase
Browse files Browse the repository at this point in the history
  • Loading branch information
Viraj Kulkarni committed Jan 30, 2025
1 parent f9cf3fa commit bcd51ec
Showing 1 changed file with 2 additions and 19 deletions.
21 changes: 2 additions & 19 deletions admiral/pkg/clusters/admiralDatabaseClient.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,11 @@ func (dynamicConfigDatabaseClient *DynamicConfigDatabaseClient) Get(env, identit

func checkIfDynamicConfigDatabaseClientIsInitialize(dynamicConfigDatabaseClient *DynamicConfigDatabaseClient) error {
if dynamicConfigDatabaseClient == nil || dynamicConfigDatabaseClient.dynamoClient == nil {
return fmt.Errorf("DynamicConfig: dynamoClient is not initialized")
return fmt.Errorf("task=%s, dynamoClient is not initialized", common.DynamicConfigUpdate)
}

if dynamicConfigDatabaseClient.database == nil {
return fmt.Errorf("DynamicConfig: database is not initialized")
return fmt.Errorf("task=%s, database is not initialized", common.DynamicConfigUpdate)
}

return nil
Expand All @@ -123,23 +123,6 @@ func (databaseClient *DummyDatabaseClient) Get(env, identity string) (interface{
return nil, nil
}

func (dynamicConfigDatabaseClient *DynamicConfigDatabaseClient) Update(data interface{}, logger *log.Entry) error {
//TODO implement me
//At point of release there is no plan to support push config to dyanmic config storage
panic("implement me")
}

func (dynamicConfigDatabaseClient *DynamicConfigDatabaseClient) Delete(data interface{}, logger *log.Entry) error {
//TODO implement me
//At point of release there is no plan to support delete config to dyanmic config storage
panic("implement me")
}

func (dynamicConfigDatabaseClient *DynamicConfigDatabaseClient) Get(env, identity string) (interface{}, error) {
//Variable renaming is done to re-purpose existing interface
return dynamicConfigDatabaseClient.dynamoClient.getDynamicConfig(env, identity, dynamicConfigDatabaseClient.database.TableName)
}

func NewAdmiralDatabaseClient(admiralConfigPath string, dynamoClientInitFunc func(string, string) (*DynamoClient, error)) (*WorkloadDatabaseClient, error) {
var workloadDatabaseClient = &WorkloadDatabaseClient{}

Expand Down

0 comments on commit bcd51ec

Please sign in to comment.