Set up some baseline stuff for this repo. (#13)

- Enable CircleCI

- Enable linting (and fix a lint error)

- Enable Mergify

- Enable codecov.io

- Add a Makefile and CONTRIBUTING.md

.circleci/config.yml

@@ -0,0 +1,40 @@
+version: 2
+
+jobs:
+  build:
+    docker:
+      - image: gcr.io/istio-testing/circleci:2019-04-22
+    working_directory: /go/src/istio.io/operator
+    steps:
+      - checkout
+      - run:
+          name: Building
+          command: go build ./...
+
+  lint:
+    docker:
+      - image: gcr.io/istio-testing/circleci:2019-04-22
+    working_directory: /go/src/istio.io/operator
+    steps:
+      - checkout
+      - run:
+          name: Linting
+          command: make lint
+
+  test:
+    docker:
+      - image: gcr.io/istio-testing/circleci:2019-04-22
+    working_directory: /go/src/istio.io/operator
+    steps:
+      - checkout
+      - run:
+          name: Running unit tests
+          command: go test -race ./...
+
+workflows:
+  version: 2
+  all:
+    jobs:
+      - build
+      - test
+      - lint

.codecov.yml

@@ -0,0 +1,2 @@
+coverage:
+  ignore:

.golangci.yml

@@ -0,0 +1,183 @@
+service:
+  # When updating this, also update bin/linters.sh accordingly
+  golangci-lint-version: 1.16.x # use the fixed version to not introduce new linters unexpectedly
+run:
+  # timeout for analysis, e.g. 30s, 5m, default is 1m
+  deadline: 20m
+
+  # which dirs to skip: they won't be analyzed;
+  # can use regexp here: generated.*, regexp is applied on full path;
+  # default value is empty list, but next dirs are always skipped independently
+  # from this option's value:
+  #   	vendor$, third_party$, testdata$, examples$, Godeps$, builtin$
+  skip-dirs:
+    - genfiles$
+    - vendor$
+
+  # which files to skip: they will be analyzed, but issues from them
+  # won't be reported. Default value is empty list, but there is
+  # no need to include all autogenerated files, we confidently recognize
+  # autogenerated files. If it's not please let us know.
+  skip-files:
+    - ".*\\.pb\\.go"
+    - ".*\\.gen\\.go"
+
+linters:
+  enable-all: true
+  disable:
+    - depguard
+    - dupl
+    - gochecknoglobals
+    - gochecknoinits
+    - goconst
+    - gocyclo
+    - gosec
+    - nakedret
+    - prealloc
+    - scopelint
+  fast: false
+
+linters-settings:
+  errcheck:
+    # report about not checking of errors in type assetions: `a := b.(MyStruct)`;
+    # default is false: such cases aren't reported by default.
+    check-type-assertions: false
+
+    # report about assignment of errors to blank identifier: `num, _ := strconv.Atoi(numStr)`;
+    # default is false: such cases aren't reported by default.
+    check-blank: false
+  govet:
+    # report about shadowed variables
+    check-shadowing: false
+  golint:
+    # minimal confidence for issues, default is 0.8
+    min-confidence: 0.0
+  gofmt:
+    # simplify code: gofmt with `-s` option, true by default
+    simplify: true
+  goimports:
+    # put imports beginning with prefix after 3rd-party packages;
+    # it's a comma-separated list of prefixes
+    local-prefixes: istio.io/
+  maligned:
+    # print struct with more effective memory layout or not, false by default
+    suggest-new: true
+  misspell:
+    # Correct spellings using locale preferences for US or UK.
+    # Default is to use a neutral variety of English.
+    # Setting locale to US will correct the British spelling of 'colour' to 'color'.
+    locale: US
+  lll:
+    # max line length, lines longer will be reported. Default is 120.
+    # '\t' is counted as 1 character by default, and can be changed with the tab-width option
+    line-length: 160
+    # tab width in spaces. Default to 1.
+    tab-width: 1
+  unused:
+    # treat code as a program (not a library) and report unused exported identifiers; default is false.
+    # XXX: if you enable this setting, unused will report a lot of false-positives in text editors:
+    # if it's called for subdir of a project it can't find funcs usages. All text editor integrations
+    # with golangci-lint call it on a directory with the changed file.
+    check-exported: false
+  unparam:
+    # call graph construction algorithm (cha, rta). In general, use cha for libraries,
+    # and rta for programs with main packages. Default is cha.
+    algo: cha
+
+    # Inspect exported functions, default is false. Set to true if no external program/library imports your code.
+    # XXX: if you enable this setting, unparam will report a lot of false-positives in text editors:
+    # if it's called for subdir of a project it can't find external interfaces. All text editor integrations
+    # with golangci-lint call it on a directory with the changed file.
+    check-exported: false
+  gocritic:
+    enabled-checks:
+      - appendCombine
+      - argOrder
+      - assignOp
+      - badCond
+      - boolExprSimplify
+      - builtinShadow
+      - captLocal
+      - caseOrder
+      - codegenComment
+      - commentedOutCode
+      - commentedOutImport
+      - defaultCaseOrder
+      - deprecatedComment
+      - docStub
+      - dupArg
+      - dupBranchBody
+      - dupCase
+      - dupSubExpr
+      - elseif
+      - emptyFallthrough
+      - equalFold
+      - flagDeref
+      - flagName
+      - hexLiteral
+      - indexAlloc
+      - initClause
+      - methodExprCall
+      - nilValReturn
+      - octalLiteral
+      - offBy1
+      - rangeExprCopy
+      - regexpMust
+      - sloppyLen
+      - stringXbytes
+      - switchTrue
+      - typeAssertChain
+      - typeSwitchVar
+      - typeUnparen
+      - underef
+      - unlambda
+      - unnecessaryBlock
+      - unslice
+      - valSwap
+      - weakCond
+      - yodaStyleExpr
+
+      # Unused
+      # - appendAssign
+      # - commentFormatting
+      # - emptyStringTest
+      # - exitAfterDefer
+      # - ifElseChain
+      # - hugeParam
+      # - importShadow
+      # - nestingReduce
+      # - paramTypeCombine
+      # - ptrToRefParam
+      # - rangeValCopy
+      # - singleCaseSwitch
+      # - sloppyReassign
+      # - unlabelStmt
+      # - unnamedResult
+      # - wrapperFunc
+
+issues:
+  # List of regexps of issue texts to exclude, empty list by default.
+  # But independently from this option we use default exclude patterns,
+  # it can be disabled by `exclude-use-default: false`. To list all
+  # excluded by default patterns execute `golangci-lint run --help`
+  exclude:
+    - composite literal uses unkeyed fields
+
+  exclude-rules:
+    # Exclude some linters from running on test files.
+    - path: _test\.go$|^tests/|^samples/
+      linters:
+        - errcheck
+        - maligned
+
+  # Independently from option `exclude` we use default exclude patterns,
+  # it can be disabled by this option. To list all
+  # excluded by default patterns execute `golangci-lint run --help`.
+  # Default value for this option is true.
+  exclude-use-default: true
+
+  # Maximum issues count per one linter. Set to 0 to disable. Default is 50.
+  max-per-linter: 0
+
+  # Maximum count of issues with the same text. Set to 0 to disable. Default is 3.
+  max-same-issues: 0

.mergify.yml

@@ -0,0 +1,15 @@
+pull_request_rules:
+  - name: Automatic merge on CI success and review
+    conditions:
+      - "status-success=ci/circleci: build"
+      - "status-success=ci/circleci: test"
+      - "status-success=ci/circleci: lint"
+      - status-success=cla/google
+      - "#approved-reviews-by>=1"
+      - label!=do-not-merge
+      - label!=do-not-merge/work-in-progress
+      - label!=do-not-merge/hold
+    actions:
+      merge:
+        method: squash
+        strict: false

CODEOWNERS

@@ -0,0 +1 @@
+*  @mostrowski @rcernich @martonsereg @waynz

CONTRIBUTING.md

@@ -0,0 +1,5 @@
+# Contribution guidelines
+
+So you want to hack on Istio? Yay! Please refer to Istio's overall
+[contribution guidelines](https://github.com/istio/community/blob/master/CONTRIBUTING.md)
+to find out how you can help.

Makefile

@@ -0,0 +1,5 @@
+lint:
+	@scripts/linters.sh
+
+format:
+	@scripts/fmt.sh

README.md

@@ -1,3 +1,10 @@
+[![CircleCI](https://circleci.com/gh/istio/operator.svg?style=svg)](https://circleci.com/gh/istio/operator)
+[![Mergify Status](https://gh.mergify.io/badges/istio/operator.png?style=cut)](https://mergify.io)
+[![Go Report Card](https://goreportcard.com/badge/github.com/istio/operator)](https://goreportcard.com/report/github.com/istio/operator)
+[![GolangCI](https://golangci.com/badges/github.com/istio/operator.svg)](https://golangci.com/r/github.com/istio/operator)
+
+# Istio Operator
+
 Update 4/22/19
 
 This repo is for the initial, alpha version of the official Istio install operator. It's currently only open to the core 

cmd/manager/main.go

@@ -10,8 +10,8 @@ import (
 	// Import all Kubernetes client auth plugins (e.g. Azure, GCP, OIDC, etc.)
 	_ "k8s.io/client-go/plugin/pkg/client/auth"
 
-	"github.com/istio-ecosystem/istio-operator/istio-operator/pkg/apis"
-	"github.com/istio-ecosystem/istio-operator/istio-operator/pkg/controller"
+	"istio.io/operator/pkg/apis"
+	"istio.io/operator/pkg/controller"
 
 	"github.com/operator-framework/operator-sdk/pkg/k8sutil"
 	"github.com/operator-framework/operator-sdk/pkg/leader"

pkg/apis/addtoscheme_istio_v1alpha1.go

@@ -1,7 +1,7 @@
 package apis
 
 import (
-	"github.com/istio-ecosystem/istio-operator/pkg/apis/istio/v1alpha1"
+	"istio.io/operator/pkg/apis/istio/v1alpha1"
 )
 
 func init() {

pkg/apis/istio/v1alpha1/istiocontrolplane_types.go

@@ -28,11 +28,11 @@ type IstioControlPlaneStatus struct {
 // IstioControlPlane is the Schema for the istiocontrolplanes API
 // +k8s:openapi-gen=true
 type IstioControlPlane struct {
-	metav1.TypeMeta   `json:",inline"`
-	metav1.ObjectMeta `json:"metadata,omitempty"`
-
 	Spec   IstioControlPlaneSpec   `json:"spec,omitempty"`
 	Status IstioControlPlaneStatus `json:"status,omitempty"`
+
+	metav1.ObjectMeta `json:"metadata,omitempty"`
+	metav1.TypeMeta   `json:",inline"`
 }
 
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object

pkg/controller/add_istiocontrolplane.go

@@ -1,7 +1,7 @@
 package controller
 
 import (
-	"github.com/istio-ecosystem/istio-operator/pkg/controller/istiocontrolplane"
+	"istio.io/operator/pkg/controller/istiocontrolplane"
 )
 
 func init() {

pkg/controller/istiocontrolplane/istiocontrolplane_controller.go

@@ -3,7 +3,7 @@ package istiocontrolplane
 import (
 	"context"
 
-	istiov1alpha1 "github.com/istio-ecosystem/istio-operator/pkg/apis/istio/v1alpha1"
+	istiov1alpha1 "istio.io/operator/pkg/apis/istio/v1alpha1"
 
 	corev1 "k8s.io/api/core/v1"
 	"k8s.io/apimachinery/pkg/api/errors"