renderers: test empty values #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pared
force-pushed
the
empty_values_tests
branch
from
abaeef4 to
3e8578d
Compare
daavoo
reviewed
Apr 4, 2022
daavoo
reviewed
Apr 4, 2022
skshetry
reviewed
Apr 4, 2022
skshetry
reviewed
Apr 4, 2022
pared
force-pushed
the
empty_values_tests
branch
2 times, most recently
from
3818e21 to
9ef9221
Compare
Codecov Report
@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 95.11% 95.68% +0.57%
==========================================
Files 14 14
Lines 450 464 +14
Branches 74 76 +2
==========================================
+ Hits 428 444 +16
+ Misses 16 15 -1
+ Partials 6 5 -1
Continue to review full report at Codecov.
|
pared
force-pushed
the
empty_values_tests
branch
from
9ef9221 to
6192375
Compare
pared
changed the title
skshetry
approved these changes
Apr 25, 2022
daavoo
reviewed
Apr 25, 2022
tests/test_vega.py
Outdated
| assert renderer.name == "" | ||
| assert renderer.properties == {} | ||
|
|
||
| renderer.partial_html() |
There was a problem hiding this comment.
Should we check the contents of the resulting template?
pared
force-pushed
the
empty_values_tests
branch
from
6192375 to
fa4aee0
Compare
daavoo
approved these changes
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: iterative/vscode-dvc#1520