TabularData: Add dropna method
#6812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daavoo can you provide some context, where this functionality will be used? |
pared
approved these changes
Oct 26, 2021
This method mimics pandas `dropna`.
daavoo
force-pushed
the
tabulardata-dropna
branch
from
fc5c0f3 to
cc4cba4
Compare
karajan1001
reviewed
Oct 28, 2021
| @@ -181,6 +182,35 @@ def as_dict( | |||
| {k: self._columns[k][i] for k in keys} for i in range(len(self)) | |||
| ] | |||
|
|
|||
| def dropna(self, axis: str = "rows"): | |||
There was a problem hiding this comment.
How about adding a new argument how : {‘any’, ‘all’}. Not required for this PR. Other useful arguments are subset that would protect some important columns / rows.
There was a problem hiding this comment.
Thats a good idea and would be in line with pandas API
There was a problem hiding this comment.
Just borrows ideas from Pandas, but Pandas is too heavy for this work.
There was a problem hiding this comment.
Wouldn't subset be effectively making --include overriding drop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pre-requisite for #4455