Remove unused NewFrontendClient functions (cadence-workflow#4553)

itildesk · Oct 11, 2021 · 7a6b851 · 7a6b851
1 parent 19a954a
commit 7a6b851
Showing 1 changed file with 0 additions and 32 deletions.
diff --git a/client/clientfactory.go b/client/clientfactory.go
@@ -64,11 +64,9 @@ type (
 	Factory interface {
 		NewHistoryClient() (history.Client, error)
 		NewMatchingClient(domainIDToName DomainIDToNameFunc) (matching.Client, error)
-		NewFrontendClient() (frontend.Client, error)
 
 		NewHistoryClientWithTimeout(timeout time.Duration) (history.Client, error)
 		NewMatchingClientWithTimeout(domainIDToName DomainIDToNameFunc, timeout time.Duration, longPollTimeout time.Duration) (matching.Client, error)
-		NewFrontendClientWithTimeout(timeout time.Duration, longPollTimeout time.Duration) (frontend.Client, error)
 
 		NewAdminClientWithTimeoutAndConfig(config transport.ClientConfig, timeout time.Duration, largeTimeout time.Duration) (admin.Client, error)
 		NewFrontendClientWithTimeoutAndConfig(config transport.ClientConfig, timeout time.Duration, longPollTimeout time.Duration) (frontend.Client, error)
@@ -117,10 +115,6 @@ func (cf *rpcClientFactory) NewMatchingClient(domainIDToName DomainIDToNameFunc)
 	return cf.NewMatchingClientWithTimeout(domainIDToName, matching.DefaultTimeout, matching.DefaultLongPollTimeout)
 }
 
-func (cf *rpcClientFactory) NewFrontendClient() (frontend.Client, error) {
-	return cf.NewFrontendClientWithTimeout(frontend.DefaultTimeout, frontend.DefaultLongPollTimeout)
-}
-
 func (cf *rpcClientFactory) createKeyResolver(serviceName string) (func(key string) (string, error), error) {
 	resolver, err := cf.monitor.GetResolver(serviceName)
 	if err != nil {
@@ -239,32 +233,6 @@ func (cf *rpcClientFactory) NewMatchingClientWithTimeout(
 
 }
 
-func (cf *rpcClientFactory) NewFrontendClientWithTimeout(
-	timeout time.Duration,
-	longPollTimeout time.Duration,
-) (frontend.Client, error) {
-	keyResolver, err := cf.createKeyResolver(service.Frontend)
-	if err != nil {
-		return nil, err
-	}
-
-	clientProvider := func(clientKey string) (interface{}, error) {
-		if cf.enableGRPCOutbound {
-			return cf.newFrontendGRPCClient(clientKey)
-		}
-		return cf.newFrontendThriftClient(clientKey)
-	}
-
-	client := frontend.NewClient(timeout, longPollTimeout, common.NewClientCache(keyResolver, clientProvider))
-	if errorRate := cf.dynConfig.GetFloat64Property(dynamicconfig.FrontendErrorInjectionRate, 0)(); errorRate != 0 {
-		client = frontend.NewErrorInjectionClient(client, errorRate, cf.logger)
-	}
-	if cf.metricsClient != nil {
-		client = frontend.NewMetricClient(client, cf.metricsClient)
-	}
-	return client, nil
-}
-
 func (cf *rpcClientFactory) NewAdminClientWithTimeoutAndConfig(
 	config transport.ClientConfig,
 	timeout time.Duration,