Merge pull request rails#5998 from aderyabin/fix7

EXPLAIN only for sqlite3
ivangitgild · Apr 26, 2012 · 9a3d579 · 9a3d579
2 parents 8cd14c0 + 9fd6403
commit 9a3d579
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 24 deletions.
diff --git a/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb b/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb
@@ -50,6 +50,31 @@ def encoding
         @connection.encoding.to_s
       end
 
+      # Returns true.
+      def supports_explain?
+        true
+      end
+
+      # DATABASE STATEMENTS ======================================
+
+      def explain(arel, binds = [])
+        sql = "EXPLAIN QUERY PLAN #{to_sql(arel, binds)}"
+        ExplainPrettyPrinter.new.pp(exec_query(sql, 'EXPLAIN', binds))
+      end
+
+      class ExplainPrettyPrinter
+        # Pretty prints the result of a EXPLAIN QUERY PLAN in a way that resembles
+        # the output of the SQLite shell:
+        #
+        #   0|0|0|SEARCH TABLE users USING INTEGER PRIMARY KEY (rowid=?) (~1 rows)
+        #   0|1|1|SCAN TABLE posts (~100000 rows)
+        #
+        def pp(result) # :nodoc:
+          result.rows.map do |row|
+            row.join('|')
+          end.join("\n") + "\n"
+        end
+      end
     end
   end
 end
diff --git a/activerecord/lib/active_record/connection_adapters/sqlite_adapter.rb b/activerecord/lib/active_record/connection_adapters/sqlite_adapter.rb
@@ -116,11 +116,6 @@ def supports_primary_key? #:nodoc:
         true
       end
 
-      # Returns true.
-      def supports_explain?
-        true
-      end
-
       def requires_reloading?
         true
       end
@@ -210,25 +205,6 @@ def type_cast(value, column) # :nodoc:
 
       # DATABASE STATEMENTS ======================================
 
-      def explain(arel, binds = [])
-        sql = "EXPLAIN QUERY PLAN #{to_sql(arel, binds)}"
-        ExplainPrettyPrinter.new.pp(exec_query(sql, 'EXPLAIN', binds))
-      end
-
-      class ExplainPrettyPrinter
-        # Pretty prints the result of a EXPLAIN QUERY PLAN in a way that resembles
-        # the output of the SQLite shell:
-        #
-        #   0|0|0|SEARCH TABLE users USING INTEGER PRIMARY KEY (rowid=?) (~1 rows)
-        #   0|1|1|SCAN TABLE posts (~100000 rows)
-        #
-        def pp(result) # :nodoc:
-          result.rows.map do |row|
-            row.join('|')
-          end.join("\n") + "\n"
-        end
-      end
-
       def exec_query(sql, name = nil, binds = [])
         log(sql, name, binds) do