Skip to content

Commit

Permalink
Merge pull request rails#5751 from rafaelfranca/fix-build
Browse files Browse the repository at this point in the history
Fix url_for when options is nil
  • Loading branch information
fxn committed Apr 5, 2012
2 parents ca879d2 + ddbd1e4 commit e535faa
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
2 changes: 1 addition & 1 deletion actionpack/lib/action_dispatch/routing/route_set.rb
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ def _generate_prefix(options = {})
end

def url_for(options)
options = (options || {}).reverse_merge!(default_url_options)
options = default_url_options.merge(options || {})

handle_positional_args(options)

Expand Down
2 changes: 1 addition & 1 deletion actionpack/lib/action_dispatch/routing/url_for.rb
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def url_options
def url_for(options = nil)
case options
when nil
_routes.url_for(url_options)
_routes.url_for(url_options.symbolize_keys)
when Hash
symbolized = {}
options.keys.each do |k|
Expand Down
9 changes: 9 additions & 0 deletions actionpack/test/controller/url_for_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -365,6 +365,15 @@ def test_with_stringified_default_url_options
assert_equal("/c/a", W.new.url_for(:controller => 'c', :action => 'a', :only_path => true))
end

def test_with_stringified_default_url_options_and_without_options
W.default_url_options['controller'] = 'c'
W.default_url_options['only_path'] = true
assert_equal("/c", W.new.url_for)

W.default_url_options['action'] = 'a'
assert_equal("/c/a", W.new.url_for)
end

def test_url_params_with_nil_to_param_are_not_in_url
assert_equal("/c/a", W.new.url_for(:only_path => true, :controller => 'c', :action => 'a', :id => Struct.new(:to_param).new(nil)))
end
Expand Down

0 comments on commit e535faa

Please sign in to comment.