Skip to content

Commit

Permalink
Move fast and break things
Browse files Browse the repository at this point in the history
Summary:
Broke the compile when I removed purge_log_after_memtable_flush.

sorrybus

Test Plan: make db_bench works now

Reviewers: haobo

Reviewed By: haobo

CC: leveldb

Differential Revision: https://reviews.facebook.net/D14037
  • Loading branch information
igorcanadi committed Nov 12, 2013
1 parent 9bc4a26 commit 9df2b21
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 9 deletions.
6 changes: 0 additions & 6 deletions db/db_bench.cc
Original file line number Diff line number Diff line change
Expand Up @@ -480,10 +480,6 @@ DEFINE_string(merge_operator, "", "The merge operator to use with the database."
" database The possible merge operators are defined in"
" utilities/merge_operators.h");

DEFINE_bool(purge_log_after_memtable_flush,
rocksdb::Options().purge_log_after_memtable_flush,
"");

namespace rocksdb {

// Helper for quickly generating random data.
Expand Down Expand Up @@ -1336,8 +1332,6 @@ class Benchmark {
);
break;
}
options.purge_log_after_memtable_flush =
FLAGS_purge_log_after_memtable_flush;
if (FLAGS_max_bytes_for_level_multiplier_additional_v.size() > 0) {
if (FLAGS_max_bytes_for_level_multiplier_additional_v.size() !=
(unsigned int)FLAGS_num_levels) {
Expand Down
3 changes: 0 additions & 3 deletions doc/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -704,9 +704,6 @@ <h1>Purging WAL files</h1>
checks will be performed with ttl being first.
</ul>

You can completely disable WAL file purging by setting
<code>Options::purge_log_after_memtable_flush</code> to false.

<h1>Other Information</h1>
<p>
Details about the <code>rocksdb</code> implementation may be found in
Expand Down

0 comments on commit 9df2b21

Please sign in to comment.