Merge pull request googlesamples#164 from tiembo/fix_warnings

Fix warnings, remove unused imports, replace deprecated method.
iyappanarms · Feb 11, 2016 · 7d48f39 · 7d48f39
2 parents d24f196 + 5fa2a17
commit 7d48f39
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/...ytics/app/src/main/java/com/google/samples/quickstart/analytics/AnalyticsApplication.java b/...ytics/app/src/main/java/com/google/samples/quickstart/analytics/AnalyticsApplication.java
@@ -19,7 +19,6 @@
 import android.app.Application;
 
 import com.google.android.gms.analytics.GoogleAnalytics;
-import com.google.android.gms.analytics.Logger;
 import com.google.android.gms.analytics.Tracker;
 
 /**

diff --git a/...id/analytics/app/src/main/java/com/google/samples/quickstart/analytics/ImageFragment.java b/...id/analytics/app/src/main/java/com/google/samples/quickstart/analytics/ImageFragment.java
@@ -17,9 +17,6 @@
 package com.google.samples.quickstart.analytics;
 
 
-import android.graphics.Bitmap;
-import android.graphics.BitmapFactory;
-import android.graphics.drawable.BitmapDrawable;
 import android.os.Bundle;
 import android.support.v4.app.Fragment;
 import android.view.LayoutInflater;
@@ -65,7 +62,7 @@ public void onCreate(Bundle savedInstanceState) {
   public View onCreateView(LayoutInflater inflater,
                            ViewGroup container,
                            Bundle savedInstanceState) {
-    View view = inflater.inflate(R.layout.fragment_main, null);
+    View view = inflater.inflate(R.layout.fragment_main, container, false);
     ImageView imageView = (ImageView) view.findViewById(R.id.imageView);
     imageView.setImageResource(resId);
 

diff --git a/...oid/analytics/app/src/main/java/com/google/samples/quickstart/analytics/MainActivity.java b/...oid/analytics/app/src/main/java/com/google/samples/quickstart/analytics/MainActivity.java
@@ -50,6 +50,7 @@ public class MainActivity extends AppCompatActivity {
    * The {@link android.support.v4.view.PagerAdapter} that will provide fragments for each image.
    * This uses a {@link FragmentPagerAdapter}, which keeps every loaded fragment in memory.
    */
+  @SuppressWarnings("FieldCanBeLocal")
   private ImagePagerAdapter mImagePagerAdapter;
 
   /**
@@ -81,7 +82,7 @@ protected void onCreate(Bundle savedInstanceState) {
     mViewPager.setAdapter(mImagePagerAdapter);
 
     // When the visible image changes, send a screen view hit.
-    mViewPager.setOnPageChangeListener(new ViewPager.SimpleOnPageChangeListener() {
+    mViewPager.addOnPageChangeListener(new ViewPager.SimpleOnPageChangeListener() {
       @Override
       public void onPageSelected(int position) {
         sendScreenImageName();