Skip to content

Commit

Permalink
Inline usage of SkIsPow2 (flutter#38722)
Browse files Browse the repository at this point in the history
* Inline usage of SkIsPow2

* static
  • Loading branch information
kjlubick authored Jan 10, 2023
1 parent b6720a5 commit 4f0cdcd
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion display_list/display_list_builder.cc
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,16 @@ static void CopyV(void* dst, const S* src, int n, Rest&&... rest) {
CopyV(SkTAddOffset<void>(dst, n * sizeof(S)), std::forward<Rest>(rest)...);
}

static constexpr inline bool is_power_of_two(int value) {
return (value & (value - 1)) == 0;
}

template <typename T, typename... Args>
void* DisplayListBuilder::Push(size_t pod, int render_op_inc, Args&&... args) {
size_t size = SkAlignPtr(sizeof(T) + pod);
FML_DCHECK(size < (1 << 24));
if (used_ + size > allocated_) {
static_assert(SkIsPow2(DL_BUILDER_PAGE),
static_assert(is_power_of_two(DL_BUILDER_PAGE),
"This math needs updating for non-pow2.");
// Next greater multiple of DL_BUILDER_PAGE.
allocated_ = (used_ + size + DL_BUILDER_PAGE) & ~(DL_BUILDER_PAGE - 1);
Expand Down

0 comments on commit 4f0cdcd

Please sign in to comment.