Skip to content

Commit

Permalink
Update legacy call to SkImage::makeSubset (flutter#43786)
Browse files Browse the repository at this point in the history
In https://skia-review.googlesource.com/c/skia/+/671679 Skia updated the
calls to SkImage::makeSubset() to always need a `GrDirectContext*`. This
updates Flutter's one call that needed it.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or Hixie said the PR is test-exempt. See [testing the engine]
for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
  • Loading branch information
kjlubick authored Jul 19, 2023
1 parent eb22852 commit 581e67b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions shell/platform/embedder/tests/embedder_unittests_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ bool ImageMatchesFixture(const std::string& fixture_file_name,
FML_CHECK(scene_image) << "Invalid scene image.";

auto scene_image_subset = scene_image->makeSubset(
nullptr,
SkIRect::MakeWH(fixture_image->width(), fixture_image->height()));

FML_CHECK(scene_image_subset)
Expand Down

0 comments on commit 581e67b

Please sign in to comment.