Skip to content

Commit

Permalink
[macos] Disable background colour tests (flutter#41904)
Browse files Browse the repository at this point in the history
These tests are flaky. Until they've been deflaked, disable the
following two tests:
* FlutterEngineTest.BackgroundIsBlack
* FlutterEngineTest.CanOverrideBackgroundColor

Issue: flutter/flutter#124677
  • Loading branch information
cbracken authored May 10, 2023
1 parent 7ad6470 commit ef771f9
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,8 @@ - (nonnull NSView*)createWithViewIdentifier:(int64_t)viewId arguments:(nullable
EXPECT_TRUE(logs.find("Hello logging") != std::string::npos);
}

TEST_F(FlutterEngineTest, BackgroundIsBlack) {
// TODO(cbracken): Needs deflaking. https://github.com/flutter/flutter/issues/124677
TEST_F(FlutterEngineTest, DISABLED_BackgroundIsBlack) {
FlutterEngine* engine = GetFlutterEngine();

// Latch to ensure the entire layer tree has been generated and presented.
Expand Down Expand Up @@ -163,7 +164,8 @@ - (nonnull NSView*)createWithViewIdentifier:(int64_t)viewId arguments:(nullable
latch.Wait();
}

TEST_F(FlutterEngineTest, CanOverrideBackgroundColor) {
// TODO(cbracken): Needs deflaking. https://github.com/flutter/flutter/issues/124677
TEST_F(FlutterEngineTest, DISABLED_CanOverrideBackgroundColor) {
FlutterEngine* engine = GetFlutterEngine();

// Latch to ensure the entire layer tree has been generated and presented.
Expand Down

0 comments on commit ef771f9

Please sign in to comment.