Tags: j-bahr/hermes
Tags
Avoid repeated branches while iterating StringView Summary: `quoteStringForJSON` was operating via indexed access on `StringView`, performing an `isASCII()` check every iteration and leading to slow quoting during `JSON.stringify`. Modify the function to take `UTF16Ref` or `ASCIIRef` directly, so that it knows the type. This increases code size slightly while resulting in significant speedups in `JSON.stringify`. Reviewed By: neildhar Differential Revision: D46117526 fbshipit-source-id: e6b849fc8b4e2e748e05d277e36462b8d97ae095
Fix Intl to clear needDefault flag correctly (facebook#1014) Summary: Similar to year, month, and day, specifying "weekday" as an option to `toLocaleString` should result in only the weekday being printed. To force this, use the `kDateRequired` bit as we do for the other fields. Pull Request resolved: facebook#1014 Test Plan: Added a test in the next diff. Reviewed By: tmikov Differential Revision: D49856174 Pulled By: neildhar fbshipit-source-id: ed52f425e4240f672931d236bc53cc58724b6747
Unsubscribe heap callbacks on destruction Summary: Disable heap object stack tracing upon destruction. Reviewed By: dannysu Differential Revision: D49477452 fbshipit-source-id: d7984c8293351727df1cf734bcb634647a1c578c
Avoid repeated branches while iterating StringView Summary: `quoteStringForJSON` was operating via indexed access on `StringView`, performing an `isASCII()` check every iteration and leading to slow quoting during `JSON.stringify`. Modify the function to take `UTF16Ref` or `ASCIIRef` directly, so that it knows the type. This increases code size slightly while resulting in significant speedups in `JSON.stringify`. Reviewed By: neildhar Differential Revision: D46117526 fbshipit-source-id: e6b849fc8b4e2e748e05d277e36462b8d97ae095
Remove register stack size override in hermes.cpp (facebook#969) Co-authored-by: Neil Dhar <[email protected]> Co-authored-by: Mike Duminy <[email protected]> resolved: facebook#923
Deploy 0.202.0 to xplat Summary: Changelog: [Internal] Reviewed By: panagosg7 Differential Revision: D44155581 fbshipit-source-id: 358df8c40395812216afef1c99f93c576a425b11
Increase default max stack size (facebook#923) Summary: As discussed in facebook#135, the default stack size doesn't work for all use cases. In particular, when very large and complex bundles are loaded in dev mode. This PR bumps the default stack size from `64*1024` (512kB) to `128*1024` (1MB). As suggested by tmikov in this comment - facebook#135 (comment). Pull Request resolved: facebook#923 Reviewed By: tmikov Differential Revision: D43630032 Pulled By: neildhar fbshipit-source-id: 5f8cff91a5f01b6507870c61efa1ce507de67940
Refactor HBC test helper Summary: Provide a new API in the test helper, `bytecodeModuleForSource`. This will return the module rather than the bytecode itself. With this new API, refactor `bytecodeForSource` to internally call into it. We will be using `bytecodeModuleForSource` in the next diff for testing purposes. Reviewed By: tmikov Differential Revision: D41670281 fbshipit-source-id: 2a6d7fb909a171a279aabcc69333ee09845d9ddd
Re-sync with internal repository (facebook#856) Co-authored-by: Facebook Community Bot <[email protected]>
type updates and transform node updates Summary: This diff: 1) fixes some bugs in the AST types 2) splits some ambiguous node types into more specific types (eg `ObjectTypeProperty` into `ObjectTypePropertySignature` and `ObjectTypeMethodSignature`) 3) refactors node transforms into separate files for cleanliness 4) adds new node creator functions for the aforementioned new node types 5) updates code to use the new functions Reviewed By: pieterv Differential Revision: D40921197 fbshipit-source-id: 42330f80814cd002a6cc70fc91915f9f8cfa654b
PreviousNext