Return proper errors on aggregated-api subresources

Return a Status object in order to avoid that the apiserver overrides all our custom errors. This allows us to finally use all return codes which we need and also improves the error reporting on the client side. Signed-off-by: Roman Mohr <[email protected]>
j-griffith · Dec 10, 2019 · acf1828 · acf1828
1 parent cbf1c22
commit acf1828
Show file tree

Hide file tree

Showing 8 changed files with 237 additions and 195 deletions.
diff --git a/pkg/virt-api/rest/BUILD.bazel b/pkg/virt-api/rest/BUILD.bazel
@@ -54,8 +54,8 @@ go_test(
         "//vendor/github.com/onsi/gomega:go_default_library",
         "//vendor/github.com/onsi/gomega/ghttp:go_default_library",
         "//vendor/k8s.io/api/core/v1:go_default_library",
+        "//vendor/k8s.io/apimachinery/pkg/api/errors:go_default_library",
         "//vendor/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
-        "//vendor/k8s.io/apimachinery/pkg/util/json:go_default_library",
         "//vendor/k8s.io/apimachinery/pkg/util/uuid:go_default_library",
         "//vendor/k8s.io/client-go/kubernetes/typed/authorization/v1beta1:go_default_library",
         "//vendor/k8s.io/client-go/tools/clientcmd:go_default_library",

diff --git a/pkg/virt-api/rest/subresource.go b/pkg/virt-api/rest/subresource.go