Refactor the pre_condition hacks into an RSpec shared context.

DRY!

spec/classes/jenkins_cli_spec.rb

@@ -1,8 +1,7 @@
 require 'spec_helper'
 
-describe 'jenkins' do
+describe 'jenkins', :type => :module do
   let(:facts) { { :osfamily => 'RedHat', :operatingsystem => 'RedHat' } }
-  let(:pre_condition) { [] }
 
   context 'cli' do
     context 'default' do

spec/classes/jenkins_config_spec.rb

@@ -1,8 +1,7 @@
 require 'spec_helper'
 
-describe 'jenkins' do
+describe 'jenkins', :type => :module do
   let(:facts) { { :osfamily => 'RedHat', :operatingsystem => 'RedHat' } }
-  let(:pre_condition) { [] }
 
   context 'config' do
     context 'default' do

spec/classes/jenkins_firewall_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe 'jenkins' do
+describe 'jenkins', :type => :module  do
   let(:facts) { { :osfamily => 'RedHat', :operatingsystem => 'RedHat' } }
   let(:pre_condition) { ["define firewall($action, $state, $dport, $proto) {}"] }
   let(:params) { { :configure_firewall => true } }

spec/classes/jenkins_package_spec.rb

@@ -1,8 +1,7 @@
 require 'spec_helper'
 
-describe 'jenkins' do
+describe 'jenkins', :type => :module do
   let(:facts) { { :osfamily => 'RedHat', :operatingsystem => 'RedHat' } }
-  let(:pre_condition) { [] }
 
   describe 'package' do
     context 'default' do

spec/classes/jenkins_plugins_spec.rb

@@ -1,8 +1,7 @@
 require 'spec_helper'
 
-describe 'jenkins' do
+describe 'jenkins', :type => :module  do
   let(:facts) { { :osfamily => 'RedHat', :operatingsystem => 'RedHat' } }
-  let(:pre_condition) { [] }
 
   context 'plugins' do
     context 'default' do

spec/classes/jenkins_proxy_spec.rb

@@ -1,8 +1,7 @@
 require 'spec_helper'
 
-describe 'jenkins' do
+describe 'jenkins', :type => :module do
   let(:facts) { { :osfamily => 'RedHat', :operatingsystem => 'RedHat' } }
-  let(:pre_condition) { [] }
 
   context 'proxy' do
     context 'default' do

spec/classes/jenkins_repo_debian_spec.rb

@@ -1,8 +1,6 @@
 require 'spec_helper'
 
-describe 'jenkins' do
-  let(:pre_condition) { [] }
-
+describe 'jenkins', :type => :module do
   # Switching OS Family to prevent duplicate declaration
   let(:facts) do
     {

spec/classes/jenkins_repo_el_spec.rb

@@ -1,9 +1,8 @@
 require 'spec_helper'
 
-describe 'jenkins' do
+describe 'jenkins', :type => :module do
   # Switching OS Family to prevent duplicate declaration
   let(:facts) { { :osfamily => 'Redhat', :operatingsystem => 'CentOS' } }
-  let(:pre_condition) { [] }
 
   context 'repo::el' do
     describe 'default' do

spec/classes/jenkins_repo_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
-describe 'jenkins' do
-  let(:pre_condition) { [] }
+describe 'jenkins', :type => :module do
 
   describe 'repo' do
     describe 'default' do

spec/classes/jenkins_repo_suse_spec.rb

@@ -1,9 +1,8 @@
 require 'spec_helper'
 
-describe 'jenkins' do
+describe 'jenkins', :type => :module do
   # Switching OS Family to prevent duplicate declaration
   let(:facts) { { :osfamily => 'Suse', :operatingsystem => 'OpenSuSE' } }
-  let(:pre_condition) { [] }
 
   context 'repo::suse' do
     describe 'default' do

spec/classes/jenkins_service_spec.rb

@@ -1,8 +1,7 @@
 require 'spec_helper'
 
-describe 'jenkins' do
+describe 'jenkins', :type => :module  do
   let(:facts) { { :osfamily => 'RedHat', :operatingsystem => 'RedHat' } }
-  let(:pre_condition) { [] }
 
   context 'service' do
     context 'default' do

spec/classes/jenkins_spec.rb

@@ -2,8 +2,7 @@
 
 # Note, rspec-puppet determines the class name from the top level describe
 # string.
-describe 'jenkins' do
-  let(:pre_condition) { [] }
+describe 'jenkins', :type => :module do
   describe "on RedHat" do
     let(:facts) do
       { :osfamily => 'RedHat', :operatingsystem => 'CentOS' }

spec/helpers/rspechelpers.rb

@@ -0,0 +1,33 @@
+require 'rubygems'
+require 'rspec'
+
+
+module Jenkins
+  module RSpecHelpers
+    def clear_facts
+    end
+
+    shared_context "custom fact example", :type => :fact do
+      # Need to make sure we clear out our facts at the start to make sure that
+      # we don't pick up some facts left over from rspec-puppet
+      #
+      # Also clear at the end to be a good citizen
+      around :each do
+        Facter.clear
+        Facter.clear_messages
+      end
+    end
+
+    shared_context "module pre-conditions", :type => :module do
+      let(:pre_condition) { [] }
+
+      before :each do
+        if pre_condition.instance_of? Array
+          pre_condition << 'class stdlib {}'
+        else
+          pre_condition = "class stdlib {} \n #{pre_condition}"
+        end
+      end
+    end
+  end
+end

spec/spec_helper.rb

@@ -4,32 +4,12 @@
 
 $LOAD_PATH.unshift(File.expand_path(File.dirname(__FILE__) + '/../'))
 
+require 'spec/helpers/rspechelpers'
+
 RSpec.configure do |c|
   # Override puppetlabs_spec_helper's stupid setting of mock_with to :mocha,
   # which is a totally piece of garbage mocking library
   c.mock_with :rspec
 
-  def clear_facts
-    Facter.clear
-    Facter.clear_messages
-  end
-
-  c.before(:each, :type => :fact) do
-    # Need to make sure we clear out our facts at the start to make sure that
-    # we don't pick up some facts left over from rspec-puppet
-    clear_facts
-  end
-  c.after(:each, :type => :fact) do
-    clear_facts
-  end
-
-  c.before :each do
-    if self.respond_to? :pre_condition
-      if pre_condition.instance_of? Array
-        pre_condition << 'class stdlib {}'
-      else
-        pre_condition = "class stdlib {} \n #{pre_condition}"
-      end
-    end
-  end
+  c.include(Jenkins::RSpecHelpers)
 end